From: Rob Herring <robh@kernel.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
Kathiravan T <kathirav@codeaurora.org>,
Balaji Prakash J <bjagadee@codeaurora.org>,
Jack Pham <jackp@codeaurora.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/6] dt-bindings: usb: dwc3: add reference clock period
Date: Fri, 13 Aug 2021 12:22:34 -0500 [thread overview]
Message-ID: <YRaqWtSK7zNhKxSN@robh.at.kernel.org> (raw)
In-Reply-To: <22f62c59471e128b681a731997a9416ab2e91acf.1628085910.git.baruch@tkos.co.il>
On Wed, Aug 04, 2021 at 05:05:07PM +0300, Baruch Siach wrote:
> Document the snps,ref-clock-period property that describes reference
> clock period when it deviates from the default set value.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 41416fbd92aa..c8027d2852cd 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -252,6 +252,15 @@ properties:
> minimum: 0
> maximum: 0x3f
>
> + snps,ref-clock-period:
> + description:
> + Value for REFCLKPER field of GUCTL register for post-silicon reference
Why is post-silicon relevant here? Everything upstream should be for
post-silicon. I've seen and done the hacks to make pre-silicon testing
work and we don't need those upstream.
> + clock period in nanoseconds, when the hardware set default does not match
If you have units, then use property unit suffix in the name.
> + the actual clock.
> + $ref: /schemas/types.yaml#/definitions/uint32
And then you can drop the type.
However, if the h/w block gets a ref clock why isn't it described in
'clocks' and then you can just read why the frequency is and calculate
the period.
next prev parent reply other threads:[~2021-08-13 17:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 14:05 [PATCH v2 1/6] dt-bindings: phy: qcom,qmp: Add IPQ6018 USB3 PHY Baruch Siach
2021-08-04 14:05 ` [PATCH v2 2/6] phy: qcom-qmp: add USB3 PHY support for IPQ6018 Baruch Siach
2021-08-06 13:05 ` Vinod Koul
2021-08-04 14:05 ` [PATCH v2 3/6] dt-bindings: usb: dwc3: add reference clock period Baruch Siach
2021-08-13 17:22 ` Rob Herring [this message]
2021-08-04 14:05 ` [PATCH v2 4/6] usb: dwc3: reference clock period configuration Baruch Siach
2021-08-04 14:11 ` Felipe Balbi
2021-08-04 14:22 ` Baruch Siach
2021-08-04 14:30 ` Felipe Balbi
2021-08-09 22:13 ` Thinh Nguyen
2021-08-13 17:27 ` Rob Herring
2021-08-13 19:52 ` Thinh Nguyen
2021-08-04 14:05 ` [PATCH v2 5/6] dt-bindings: usb: qcom,dwc3: add binding for IPQ6018 Baruch Siach
2021-08-13 17:28 ` Rob Herring
2021-08-04 14:05 ` [PATCH v2 6/6] arm64: qcom: ipq6018: add usb3 DT description Baruch Siach
2021-08-06 13:05 ` [PATCH v2 1/6] dt-bindings: phy: qcom,qmp: Add IPQ6018 USB3 PHY Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRaqWtSK7zNhKxSN@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=baruch@tkos.co.il \
--cc=bjagadee@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jackp@codeaurora.org \
--cc=kathirav@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).