From: Johan Hovold <johan@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>,
syzbot <syzbot+ada0f7d3d9fd2016d927@syzkaller.appspotmail.com>,
syzkaller-bugs@googlegroups.com,
USB mailing list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] USB: core: Make usb_start_wait_urb() interruptible
Date: Tue, 31 Aug 2021 13:10:32 +0200 [thread overview]
Message-ID: <YS4OKKox+gZZZ/vV@hovoldconsulting.com> (raw)
In-Reply-To: <YS3y14DBrg0+n/iI@hovoldconsulting.com>
On Tue, Aug 31, 2021 at 11:13:59AM +0200, Johan Hovold wrote:
> On Mon, Aug 30, 2021 at 10:46:13AM -0400, Alan Stern wrote:
> > Consider that a control message in a driver is likely to use the
> > default USB_CTRL_[GS]ET_TIMEOUT value of 5 seconds. Does it make sense
> > to allow uninterruptible wait states to last as long as that?
>
> Perhaps sometimes? I don't have a use case at hand, but I haven't
> reviewed all drivers either.
>
> The comment above usb_start_wait_urb() (which also needs to be updated,
> by the way) even suggests that drivers should "implement their own
> interruptible routines" so perhaps this has just gone unnoticed for 20
> odd years. And the question then becomes, why didn't we use
> interruptible sleep from the start?
>
> And trying to answer that I find that that's precisely what we did, but
> for some reason it was changed to uninterruptible sleep in v2.4.11
> without a motivation (that I could easily find spelled out).
Here it is:
https://lore.kernel.org/lkml/20010818013101.A7058@devserv.devel.redhat.com/
It's rationale does not seem valid anymore (i.e. the NULL deref), but
the example is still instructive.
If you close for example a v4l application you still expect the device
to be shut down orderly but with interruptible sleep all control
requests during shutdown will be aborted immediately.
Similar for USB serial devices which would for example fail to deassert
DTR/RTS, etc. (I just verified with the patch applied.)
Johan
next prev parent reply other threads:[~2021-08-31 11:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 15:52 [syzbot] INFO: task hung in do_proc_bulk syzbot
2021-08-28 18:03 ` Alan Stern
2021-08-28 20:05 ` syzbot
2021-08-29 1:58 ` [PATCH] USB: core: Make usb_start_wait_urb() interruptible Alan Stern
2021-08-30 7:56 ` Johan Hovold
2021-08-30 14:46 ` Alan Stern
2021-08-30 15:11 ` Oliver Neukum
2021-08-30 16:09 ` Alan Stern
2021-08-31 8:52 ` Oliver Neukum
2021-08-31 9:13 ` Johan Hovold
2021-08-31 10:47 ` Oliver Neukum
2021-08-31 11:02 ` Oliver Neukum
2021-08-31 11:10 ` Johan Hovold [this message]
2021-08-31 17:03 ` Alan Stern
2021-09-01 8:16 ` Oliver Neukum
2021-09-02 20:04 ` [syzbot] INFO: task hung in do_proc_bulk Alan Stern
2021-09-02 20:46 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS4OKKox+gZZZ/vV@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+ada0f7d3d9fd2016d927@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).