From: Greg KH <greg@kroah.com>
To: Niklas Lantau <niklaslantau@gmail.com>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Usb: storage: usb: removed useless cast of void*
Date: Thu, 26 Aug 2021 13:23:32 +0200 [thread overview]
Message-ID: <YSd5tKoxq2yABc+U@kroah.com> (raw)
In-Reply-To: <20210821121134.23205-1-niklaslantau@gmail.com>
On Sat, Aug 21, 2021 at 02:11:34PM +0200, Niklas Lantau wrote:
> Removed useless cast of a void* and changed __us to data
Why did you do two different things in the same patch?
If you want to work on coding style cleanups, I recommend starting in
the drivers/staging/ area to gain experience before venturing out into
the rest of the kernel.
thanks,
greg k-h
prev parent reply other threads:[~2021-08-26 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 12:11 [PATCH] Usb: storage: usb: removed useless cast of void* Niklas Lantau
2021-08-26 11:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSd5tKoxq2yABc+U@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=niklaslantau@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).