linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Ulrich Huber <ulrich@huberulrich.de>
Cc: linux-usb@vger.kernel.org
Subject: Re: ucsi_acpi GET_CONNECTOR_STATUS failed (-5)
Date: Thu, 26 Aug 2021 17:25:03 +0300	[thread overview]
Message-ID: <YSekP0+tq6ISq6my@kuha.fi.intel.com> (raw)
In-Reply-To: <a7f971ef-c3aa-aadc-e453-4c667a414131@huberulrich.de>

On Wed, Aug 25, 2021 at 08:37:14PM +0200, Ulrich Huber wrote:
> Hi,
> 
> I just managed to get some more details. The bug definitely originates from
> `ucsi_handle_connector_change`. Within this function it is the second call
> to ucsi_send_command with UCSI_GET_CONNECTOR_STATUS that fails (Step 4).
> 
> `ucsi_send_command` calls `ucsi_exec_command` internally, which does the
> synchronous write and following read. Within `ucsi_exec_command` the check
> on line 134 fails:
> 
> if (cci & UCSI_CCI_COMMAND_COMPLETE)
> 
> Hope this is of some help.

Thanks for debugging this.

Yeah, I think that the second GET_CONNECTOR_STATUS immediately after
the first one is confusing the firmware on some boards.

I'll send you a patch series I've been working on that tries to
improve the situation. I better include the list as well (sending it
as RFC).

thanks,

-- 
heikki

  reply	other threads:[~2021-08-26 14:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 14:29 ucsi_acpi GET_CONNECTOR_STATUS failed (-5) Ulrich Huber
2021-08-25  8:12 ` Heikki Krogerus
2021-08-25 13:53   ` Ulrich Huber
2021-08-25 18:37     ` Ulrich Huber
2021-08-26 14:25       ` Heikki Krogerus [this message]
2021-08-26 19:50         ` Ulrich Huber
2021-08-28  9:48           ` Heikki Krogerus
2021-08-29 11:02             ` Ulrich Huber
2021-09-09 12:19               ` Heikki Krogerus
2021-09-09 12:24                 ` Ulrich Huber
2021-09-13 13:32                   ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSekP0+tq6ISq6my@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=ulrich@huberulrich.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).