From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5AEC433F5 for ; Tue, 21 Sep 2021 14:24:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 696D061168 for ; Tue, 21 Sep 2021 14:24:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233597AbhIUOZc (ORCPT ); Tue, 21 Sep 2021 10:25:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:57730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233532AbhIUOZb (ORCPT ); Tue, 21 Sep 2021 10:25:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9C8EA60F9E; Tue, 21 Sep 2021 14:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632234243; bh=9WARhs+k0pqRjHLDOHleyu8Ol/HQbbqeHbWZToPCYVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UyJcEjf7KkeR7mit9szzE5TMxyx7Z7Jy7Xo4Nb2hxA427jC0BYcnhUhaGDw+0qUFG HjSwrqy0kYE/KlLPvoyFVW5EbZr1IrNJ57qYVHK+jlnfn8N9YwRQFIC1K+EoM0OpQl wD4ACnjy1y4q3vs4RYPY1a1T5dmj0KP3+D05hua0= Date: Tue, 21 Sep 2021 16:23:58 +0200 From: Greg Kroah-Hartman To: Salvatore Bonaccorso Cc: linux-usb@vger.kernel.org, Ben Hutchings Subject: Re: [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON dependency" Message-ID: References: <20170418023639.GE4152decadent!org!uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, Sep 18, 2021 at 02:56:27PM +0200, Salvatore Bonaccorso wrote: > Hi Greg, > > On Sat, Sep 18, 2021 at 02:41:45PM +0200, Greg Kroah-Hartman wrote: > > On Sat, Sep 18, 2021 at 02:32:40PM +0200, Salvatore Bonaccorso wrote: > > > Hi Greg, > > > > > > This is a reply to a very old patch submission: > > > > > > On Tue, Apr 18, 2017 at 02:36:39AM +0000, Ben Hutchings wrote: > > > > > > > > This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for > > > > USB_LED_TRIG. This config symbol has bool type and enables extra code > > > > in usb_common itself, not a separate driver. Enabling it should not > > > > force usb_common to be built-in! > > > > > > > > Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency") > > > > Signed-off-by: Ben Hutchings > > > > --- > > > > drivers/usb/Kconfig | 3 +-- > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > > > > index fbe493d44e81..8270abe6c677 100644 > > > > --- a/drivers/usb/Kconfig > > > > +++ b/drivers/usb/Kconfig > > > > @@ -154,8 +154,7 @@ source "drivers/usb/gadget/Kconfig" > > > > =20 > > > > config USB_LED_TRIG > > > > bool "USB LED Triggers" > > > > - depends on LEDS_CLASS && LEDS_TRIGGERS > > > > - select USB_COMMON > > > > + depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS > > > > help > > > > This option adds LED triggers for USB host and/or gadget activity. > > > > > > Was going through the series of patches we had applied in Debian and > > > noticed while this was submitted by Ben back in 2017, it looks it was > > > never applied or considered. Would that be something you could pick > > > up? I'm inlining the original patch from Ben. > > > > > > Regards, > > > Salvatore > > > > > > From: Ben Hutchings > > > Date: Wed, 11 Jan 2017 04:30:40 +0000 > > > Subject: Partially revert "usb: Kconfig: using select for USB_COMMON dependency" > > > > > > This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for > > > USB_LED_TRIG. This config symbol has bool type and enables extra code > > > in usb_common itself, not a separate driver. Enabling it should not > > > force usb_common to be built-in! > > > > > > Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency") > > > Signed-off-by: Ben Hutchings > > > --- > > > drivers/usb/common/Kconfig | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/usb/common/Kconfig b/drivers/usb/common/Kconfig > > > index d611477aae41..196f4a397587 100644 > > > --- a/drivers/usb/common/Kconfig > > > +++ b/drivers/usb/common/Kconfig > > > @@ -6,8 +6,7 @@ config USB_COMMON > > > > > > config USB_LED_TRIG > > > bool "USB LED Triggers" > > > - depends on LEDS_CLASS && LEDS_TRIGGERS > > > - select USB_COMMON > > > + depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS > > > help > > > This option adds LED triggers for USB host and/or gadget activity. > > > > > > > I would need it submitted in a format that I can apply it in, and your > > signed-off-by: added as well as it is coming through you. > > Thanks for confirming! Find it attached/inline in a git am applicable > form and the Signed-off-by added. > > Regards, > Salvatore > > >From de72d7df728722515b9700ff673a88ca6f8d9ace Mon Sep 17 00:00:00 2001 > From: Ben Hutchings > Date: Wed, 11 Jan 2017 04:30:40 +0000 > Subject: [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON > dependency" > > This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for > USB_LED_TRIG. This config symbol has bool type and enables extra code > in usb_common itself, not a separate driver. Enabling it should not > force usb_common to be built-in! > > Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency") > Signed-off-by: Ben Hutchings > Signed-off-by: Salvatore Bonaccorso > --- > drivers/usb/common/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/common/Kconfig b/drivers/usb/common/Kconfig > index 5e8a04e3dd3c..b856622431a7 100644 > --- a/drivers/usb/common/Kconfig > +++ b/drivers/usb/common/Kconfig > @@ -6,8 +6,7 @@ config USB_COMMON > > config USB_LED_TRIG > bool "USB LED Triggers" > - depends on LEDS_CLASS && LEDS_TRIGGERS > - select USB_COMMON > + depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS > help > This option adds LED triggers for USB host and/or gadget activity. > > -- > 2.33.0 > I need this as a real submission, not as part of a previous email. thanks, greg k-h