From: Greg KH <gregkh@linuxfoundation.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: stern@rowland.harvard.edu, mr.yming81@gmail.com,
chunfeng.yun@mediatek.com, matthias.bgg@gmail.com,
nishadkamdar@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, eddie.hung@mediatek.com
Subject: Re: [PATCH] xhci: Fix USB 3.1 enumeration issues by increasing roothub power-on-good delay
Date: Fri, 5 Nov 2021 17:15:42 +0100 [thread overview]
Message-ID: <YYVYrksU5/aCB3Fd@kroah.com> (raw)
In-Reply-To: <20211105160036.549516-1-mathias.nyman@linux.intel.com>
On Fri, Nov 05, 2021 at 06:00:36PM +0200, Mathias Nyman wrote:
> Some USB 3.1 enumeration issues were reported after the hub driver removed
> the minimum 100ms limit for the power-on-good delay.
>
> Since commit 90d28fb53d4a ("usb: core: reduce power-on-good delay time of
> root hub") the hub driver sets the power-on-delay based on the
> bPwrOn2PwrGood value in the hub descriptor.
>
> xhci driver has a 20ms bPwrOn2PwrGood value for both roothubs based
> on xhci spec section 5.4.8, but it's clearly not enough for the
> USB 3.1 devices, causing enumeration issues.
>
> Tests indicate full 100ms delay is needed.
>
> Reported-by: Walt Jr. Brake <mr.yming81@gmail.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
So this needs:
Fixes: 90d28fb53d4a ("usb: core: reduce power-on-good delay time of root hub")
right?
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-05 16:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 1:20 [PATCH v2] usb: core: reduce power-on-good delay time of root hub Chunfeng Yun
2021-11-01 3:33 ` Walt Jr. Brake
[not found] ` <5e907ccd-40bb-2ece-fe05-1a65a74f3aa2@gmail.com>
2021-11-01 14:06 ` Alan Stern
2021-11-02 9:05 ` Mathias Nyman
2021-11-02 20:29 ` Walt Jr. Brake
2021-11-03 20:37 ` Mathias Nyman
2021-11-05 10:00 ` Greg Kroah-Hartman
2021-11-05 13:30 ` Alan Stern
2021-11-05 16:00 ` [PATCH] xhci: Fix USB 3.1 enumeration issues by increasing roothub power-on-good delay Mathias Nyman
2021-11-05 16:09 ` Mathias Nyman
2021-11-05 17:32 ` Walt Jr. Brake
2021-11-05 19:41 ` Mathias Nyman
2021-11-05 16:15 ` Greg KH [this message]
2021-11-05 19:56 ` Mathias Nyman
2021-11-06 14:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYVYrksU5/aCB3Fd@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chunfeng.yun@mediatek.com \
--cc=eddie.hung@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mr.yming81@gmail.com \
--cc=nishadkamdar@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).