linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Lars Gunnarsson <gunnarsson.lars@gmail.com>
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 0/5] tools/usbip: Patch set summary
Date: Fri, 3 Dec 2021 12:17:09 +0100	[thread overview]
Message-ID: <Yan8tanF5oNjZT5m@kroah.com> (raw)
In-Reply-To: <20211130222254.GA16447@dell-precision-T3610>

On Tue, Nov 30, 2021 at 11:22:54PM +0100, Lars Gunnarsson wrote:
> To forward a remote usb device over usbip the following steps is required:
> 
> 1. Execute "usbip bind" on remote end.
> 2. Execute "usbip attach" on local end.
> 
> These steps must be perfomed in above order and after usb device is plugged in.
> If the usb device is unplugged on the remote end the steps above needs to be
> performed again to establish the connection. This patch set implements a feature
> to persistently forward devices on a given bus. When using flag "-p|--persistent"
> on remot end, the USB device becomes exported when plugged in. When using flag
> "-p|--persistent" on local end, the USB device becomes imported when available
> on remote end. Thus it is only required to run the usbip command once on each
> end, in any order, to persistently forward usb devices on a given bus.
> 
> This is sent in five separate patches:
>   tools/usbip: update protocol documentation
>   tools/usbip: update manual pages
>   tools/usbip: add usb event monitor into libusbip
>   tools/usbip: export USB devices on a given bus persistently
>   tools/usbip: import USB devices on a given bus persistently

Oh wow, this patch series subject lines and threading is crazy, there is
no way to figure out what is going on here.

This is what this series looks like in my mailbox:

	Nov 30 Lars Gunnarsson ( 479) [PATCH v4 5/5] tools/usbip: import USB devices on a given bus persistentl
	Nov 30 Lars Gunnarsson ( 206) [PATCH v5 4/5] tools/usbip: export USB devices on a given bus persistentl
	Nov 30 Lars Gunnarsson ( 292) [PATCH v4 3/5] tools/usbip: add usb event monitor into libusbip
	Nov 30 Lars Gunnarsson (  86) [PATCH v2 2/5] tools/usbip: update manual pages
	Nov 30 Lars Gunnarsson ( 118) [PATCH v3 1/5] tools/usbip: update protocol documentation
	Nov 30 Lars Gunnarsson (  20) [PATCH v6 0/5] tools/usbip: Patch set summary


You have a mix of "v" levels and nothing is threaded at all, showing
what patch is related to what.  Look at the lore.kernel.org link for
this, which shows none of the patches in the series:
	https://lore.kernel.org/all/20211130222254.GA16447@dell-precision-T3610/

Please use tools like 'git send-email' and 'git format-patch' to send
and create patches if you don't want to do it by hand as they will
handle the threading and versioning properly for you automatically.

Here's how a patch series looks in my mailbox that was done correctly as
contrast:

	Nov 24 Prashant Malani (  34) [PATCH 0/4] usb: Use notifier for linking Type C ports.
	Nov 26 Heikki Krogerus (  32) ├─>
	Nov 30 Heikki Krogerus (  40) │ └─>
	Nov 30 Prashant Malani (  57) │   └─>
	Dec 01 Heikki Krogerus (  77) │     └─>
	Nov 24 Prashant Malani ( 109) ├─>[PATCH 1/4] usb: typec: Add port registration notifier
	Nov 24 Prashant Malani ( 114) │ └─>
	Nov 24 Prashant Malani ( 199) ├─>[PATCH 2/4] usb: Use notifier to link Type C ports
	Nov 25 kernel test rob (  55) │ └─>
	Nov 24 Prashant Malani (  92) ├─>[PATCH 4/4] Revert "usb: Iterator for ports"
	Nov 24 Prashant Malani (  60) └─>[PATCH 3/4] usb: Link the ports to the connectors they are attached t

See how the patches are linked together?  That is because the correct
"In-Reply-To:" lines are being set.

Please fix up and resend as a "v7" patch series for ALL patches (patch
versions are for the whole series, not for individual patches, otherwise
it is crazy to try to track...)

thanks,

greg k-h

  reply	other threads:[~2021-12-03 11:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 22:22 [PATCH v6 0/5] tools/usbip: Patch set summary Lars Gunnarsson
2021-12-03 11:17 ` Greg KH [this message]
2021-12-06 20:02 ` Shuah Khan
2021-12-09 21:11   ` Lars Gunnarsson
2021-12-14 22:22     ` Shuah Khan
2021-12-16 21:01       ` Lars Gunnarsson
2021-12-23 19:22         ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yan8tanF5oNjZT5m@kroah.com \
    --to=greg@kroah.com \
    --cc=gunnarsson.lars@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).