From: Alan Stern <stern@rowland.harvard.edu>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: ohci-s3c2410: Use platform_get_irq() to get the interrupt
Date: Thu, 16 Dec 2021 11:10:36 -0500 [thread overview]
Message-ID: <Ybtk/KaLV6h+U9h5@rowland.harvard.edu> (raw)
In-Reply-To: <20211215225358.1993774-1-robh@kernel.org>
On Wed, Dec 15, 2021 at 04:53:57PM -0600, Rob Herring wrote:
> Accessing platform device resources directly has long been deprecated for
> DT as IRQ resources may not be available at device creation time. Drivers
> relying on the static IRQ resources is blocking removing the static setup
> from the DT core code.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/host/ohci-s3c2410.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb/host/ohci-s3c2410.c
> index 1bec9b585e2d..12264c048601 100644
> --- a/drivers/usb/host/ohci-s3c2410.c
> +++ b/drivers/usb/host/ohci-s3c2410.c
> @@ -356,7 +356,7 @@ static int ohci_hcd_s3c2410_probe(struct platform_device *dev)
> {
> struct usb_hcd *hcd = NULL;
> struct s3c2410_hcd_info *info = dev_get_platdata(&dev->dev);
> - int retval;
> + int retval, irq;
>
> s3c2410_usb_set_power(info, 1, 1);
> s3c2410_usb_set_power(info, 2, 1);
> @@ -388,9 +388,15 @@ static int ohci_hcd_s3c2410_probe(struct platform_device *dev)
> goto err_put;
> }
>
> + irq = platform_get_irq(dev, 0);
> + if (irq < 0) {
> + retval = irq;
> + goto err_put;
> + }
> +
> s3c2410_start_hc(dev, hcd);
>
> - retval = usb_add_hcd(hcd, dev->resource[1].start, 0);
> + retval = usb_add_hcd(hcd, irq, 0);
> if (retval != 0)
> goto err_ioremap;
>
> --
> 2.32.0
>
prev parent reply other threads:[~2021-12-16 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 22:53 [PATCH] usb: ohci-s3c2410: Use platform_get_irq() to get the interrupt Rob Herring
2021-12-16 7:38 ` Krzysztof Kozlowski
2021-12-16 16:10 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybtk/KaLV6h+U9h5@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).