From: Prashant Malani <pmalani@chromium.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
bleung@chromium.org, swboyd@chromium.org,
heikki.krogerus@linux.intel.com,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"José Expósito" <jose.exposito89@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Maxime Ripard" <maxime@cerno.tech>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Pin-Yen Lin" <treapking@chromium.org>,
"Robert Foss" <robert.foss@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Xin Ji" <xji@analogixsemi.com>
Subject: Re: [PATCH 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support
Date: Wed, 8 Jun 2022 17:08:12 +0000 [thread overview]
Message-ID: <YqDXfGa9bugnLFGH@chromium.org> (raw)
In-Reply-To: <fbc48d41-b2cc-86f6-5f1c-7cfcbdb41e46@linaro.org>
Hi Krzysztof,
Thank you for looking at the patch.
On Jun 08 11:24, Krzysztof Kozlowski wrote:
> On 07/06/2022 21:00, Prashant Malani wrote:
> > Analogix 7625 can be used in systems to switch USB Type-C DisplayPort
> > alternate mode lane traffic between 2 Type-C ports.
> >
> > Update the binding to accommodate this usage by introducing a switch
> > property.
> >
> > Signed-off-by: Prashant Malani <pmalani@chromium.org>
> > ---
> > .../display/bridge/analogix,anx7625.yaml | 56 +++++++++++++++++++
> > 1 file changed, 56 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index 35a48515836e..7e1f655ddfcc 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -105,6 +105,26 @@ properties:
> > - port@0
> > - port@1
> >
> > + switches:
> > + type: object
> > + description: Set of switches controlling DisplayPort traffic on
> > + outgoing RX/TX lanes to Type C ports.
> > +
> > + properties:
> > + switch:
>
> You allow only one switch with such schema, so no need for "switches"...
See below comment (summary: we'd like to allow 1 or 2 switches).
>
> > + $ref: /schemas/usb/typec-switch.yaml#
> > + maxItems: 2
>
> Are you sure this works? what are you limiting here with maxItems? I
> think you wanted patternProperties...
Yeah, I might not have used the DT syntax correctly here.
What I'm aiming for is:
"switches" should can contain 1 or 2 "switch" nodes.
2 is the maximum (limitation of the hardware).
>
> > +
> > + properties:
> > + reg:
> > + maxItems: 1
> > +
> > + required:
> > + - reg
> > +
> > + required:
> > + - switch@0
>
> This does not match the property.
>
> You also need unevaluatedProperties:false
Ack, will update this in the next version.
>
>
> > +
> > required:
> > - compatible
> > - reg
> > @@ -167,5 +187,41 @@ examples:
> > };
> > };
> > };
> > + switches {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + switch@0 {
> > + compatible = "typec-switch";
> > + reg = <0>;
> > + mode-switch;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@0 {
> > + reg = <0>;
> > + anx_typec0: endpoint {
> > + remote-endpoint = <&typec_port0>;
>
> Messed up indentation. Your previous patch should also switch to 4-space
> as recommended by schema coding style.
Sorry about that, will fix up the indentation in the next version.
>
> > + };
> > + };
> > + };
> > + };
> > + switch@1 {
> > + compatible = "typec-switch";
> > + reg = <1>;
> > + mode-switch;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@0 {
> > + reg = <0>;
> > + anx_typec1: endpoint {
> > + remote-endpoint = <&typec_port1>;
>
> Ditto.
>
> > + };
> > + };
> > + };
> > + };
> > + };
> > };
> > };
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-06-08 17:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 19:00 [PATCH 0/7] usb: typec: Introduce typec-switch binding Prashant Malani
2022-06-07 19:00 ` [PATCH 1/7] usb: typec: mux: Allow muxes to specify mode-switch Prashant Malani
2022-06-07 19:00 ` [PATCH 2/7] usb: typec: mux: Add CONFIG guards for functions Prashant Malani
2022-06-08 20:13 ` Prashant Malani
2022-06-07 19:00 ` [PATCH 3/7] dt-bindings: usb: Add Type-C switch binding Prashant Malani
2022-06-08 9:18 ` Krzysztof Kozlowski
2022-06-08 9:21 ` Krzysztof Kozlowski
2022-06-08 17:15 ` Prashant Malani
2022-06-09 6:43 ` Krzysztof Kozlowski
2022-06-07 19:00 ` [PATCH 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Prashant Malani
2022-06-08 9:24 ` Krzysztof Kozlowski
2022-06-08 17:08 ` Prashant Malani [this message]
2022-06-08 21:56 ` Prashant Malani
2022-06-09 6:41 ` Krzysztof Kozlowski
2022-06-09 18:24 ` Prashant Malani
2022-06-07 19:00 ` [PATCH 5/7] drm/bridge: anx7625: Register number of Type C switches Prashant Malani
2022-06-07 19:00 ` [PATCH 6/7] drm/bridge: anx7625: Register Type-C mode switches Prashant Malani
2022-06-08 18:14 ` kernel test robot
2022-06-08 18:35 ` kernel test robot
2022-06-08 22:31 ` kernel test robot
2022-06-07 19:00 ` [PATCH 7/7] drm/bridge: anx7625: Add typec_mux_set callback function Prashant Malani
2022-06-09 0:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqDXfGa9bugnLFGH@chromium.org \
--to=pmalani@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=bleung@chromium.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jose.exposito89@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=swboyd@chromium.org \
--cc=treapking@chromium.org \
--cc=tzimmermann@suse.de \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).