* [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform
@ 2022-10-06 9:52 Vadym Kochan
2022-10-06 13:53 ` Alan Stern
2022-10-06 19:26 ` Greg Kroah-Hartman
0 siblings, 2 replies; 4+ messages in thread
From: Vadym Kochan @ 2022-10-06 9:52 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman, linux-usb, linux-kernel
Cc: Elad Nachman, Yuval Shaia, Vadym Kochan
From: Elad Nachman <enachman@marvell.com>
Signed-off-by: Elad Nachman <enachman@marvell.com>
Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
---
drivers/usb/host/ehci-orion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
index a3454a3ea4e0..c6205abebbdf 100644
--- a/drivers/usb/host/ehci-orion.c
+++ b/drivers/usb/host/ehci-orion.c
@@ -230,7 +230,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
* set. Since shared usb code relies on it, set it here for
* now. Once we have dma capability bindings this can go away.
*/
- err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
+ err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
if (err)
goto err;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform
2022-10-06 9:52 [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform Vadym Kochan
@ 2022-10-06 13:53 ` Alan Stern
2022-10-06 19:26 ` Greg Kroah-Hartman
1 sibling, 0 replies; 4+ messages in thread
From: Alan Stern @ 2022-10-06 13:53 UTC (permalink / raw)
To: Vadym Kochan
Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, Elad Nachman, Yuval Shaia
On Thu, Oct 06, 2022 at 12:52:57PM +0300, Vadym Kochan wrote:
> From: Elad Nachman <enachman@marvell.com>
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
> ---
> drivers/usb/host/ehci-orion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
> index a3454a3ea4e0..c6205abebbdf 100644
> --- a/drivers/usb/host/ehci-orion.c
> +++ b/drivers/usb/host/ehci-orion.c
> @@ -230,7 +230,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
> * set. Since shared usb code relies on it, set it here for
> * now. Once we have dma capability bindings this can go away.
> */
> - err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> + err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
> if (err)
> goto err;
Apart from the fact that you didn't include a patch description, how
come the Subject: line says this applies to the AC5 platform when the
actual code change applies to all platforms? Do you know that this
change is safe for all those other platforms?
Alan Stern
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform
2022-10-06 9:52 [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform Vadym Kochan
2022-10-06 13:53 ` Alan Stern
@ 2022-10-06 19:26 ` Greg Kroah-Hartman
2022-10-09 7:10 ` Vadym Kochan
1 sibling, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2022-10-06 19:26 UTC (permalink / raw)
To: Vadym Kochan
Cc: Alan Stern, linux-usb, linux-kernel, Elad Nachman, Yuval Shaia
On Thu, Oct 06, 2022 at 12:52:57PM +0300, Vadym Kochan wrote:
> From: Elad Nachman <enachman@marvell.com>
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
For obvious reasons, I can't take patches without any changelog text.
Nor would you want me to do so. Please read the documentation for how
to write a good changelog text.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform
2022-10-06 19:26 ` Greg Kroah-Hartman
@ 2022-10-09 7:10 ` Vadym Kochan
0 siblings, 0 replies; 4+ messages in thread
From: Vadym Kochan @ 2022-10-09 7:10 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alan Stern, linux-usb, linux-kernel, Elad Nachman, Yuval Shaia
Hi Alan, Greg,
On Thu, 6 Oct 2022 21:26:43 +0200, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Thu, Oct 06, 2022 at 12:52:57PM +0300, Vadym Kochan wrote:
> > From: Elad Nachman <enachman@marvell.com>
> >
> > Signed-off-by: Elad Nachman <enachman@marvell.com>
> > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
>
> For obvious reasons, I can't take patches without any changelog text.
> Nor would you want me to do so. Please read the documentation for how
> to write a good changelog text.
Sorry for that.
>
> thanks,
>
> greg k-h
The AC5 is a 64-bit SoC, from my understanding - for 32-bit
system the 64-bit mask should be truncated to 32-bit.
Regards,
Vadym
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-09 7:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 9:52 [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform Vadym Kochan
2022-10-06 13:53 ` Alan Stern
2022-10-06 19:26 ` Greg Kroah-Hartman
2022-10-09 7:10 ` Vadym Kochan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).