From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: John Youn <John.Youn@synopsys.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Subject: [PATCH] usb: dwc3: Remove old comment
Date: Thu, 14 May 2020 17:08:38 -0700 [thread overview]
Message-ID: <a13a2738dab5a37182396570db68440ed8ff2c6e.1589500544.git.thinhn@synopsys.com> (raw)
With the new IP version checking scheme, we're not using the bit 31 of
dwc->revision as a flag anymore. Remove the stale comment.
Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
---
Hi Felipe,
Not sure what happened to the DWC_usb32 patch* when it was merged to your
testing/next branch, but the old comment was removed in that patch. You can
apply this or squash it to the patch "usb: dwc3: Add support for DWC_usb32 IP"
on your testing/next branch.
*Original patch:
https://patchwork.kernel.org/patch/11484297/
Thanks,
Thinh
drivers/usb/dwc3/core.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index d800f8119195..013f42a2b5dc 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1153,10 +1153,6 @@ struct dwc3 {
#define DWC3_REVISION_310A 0x5533310a
#define DWC3_REVISION_330A 0x5533330a
-/*
- * NOTICE: we're using bit 31 as a "is usb 3.1" flag. This is really
- * just so dwc31 revisions are always larger than dwc3.
- */
#define DWC31_REVISION_ANY 0x0
#define DWC31_REVISION_110A 0x3131302a
#define DWC31_REVISION_120A 0x3132302a
--
2.11.0
next reply other threads:[~2020-05-15 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 0:08 Thinh Nguyen [this message]
2020-05-15 9:29 ` [PATCH] usb: dwc3: Remove old comment Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a13a2738dab5a37182396570db68440ed8ff2c6e.1589500544.git.thinhn@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=John.Youn@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).