From: Markus Elfring <Markus.Elfring@web.de>
To: Rustam Kovhaev <rkovhaev@gmail.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jakub Kicinski <kuba@kernel.org>,
syzbot+67b2bd0e34f952d0321e@syzkaller.appspotmail.com
Subject: Re: [PATCH] usb: hso: check for return value in hso_serial_common_create()
Date: Tue, 28 Jul 2020 15:19:00 +0200 [thread overview]
Message-ID: <a42328b6-6d45-577f-f605-337b91c19f1a@web.de> (raw)
> in case of an error tty_register_device_attr() returns ERR_PTR(),
> add IS_ERR() check
I suggest to improve this change description a bit.
Will the tag “Fixes” become helpful for the commit message?
…
> +++ b/drivers/net/usb/hso.c
…
> @@ -2311,6 +2313,7 @@ static int hso_serial_common_create(struct hso_serial *serial, int num_urbs,
> return 0;
> exit:
> hso_serial_tty_unregister(serial);
> +exit2:
> hso_serial_common_free(serial);
> return -1;
> }
Can other labels (like “unregister_serial” and “free_serial”) be preferred here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=92ed301919932f777713b9172e525674157e983d#n485
Regards,
Markus
next reply other threads:[~2020-07-28 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 13:19 Markus Elfring [this message]
2020-07-28 15:30 ` [PATCH] usb: hso: check for return value in hso_serial_common_create() Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2020-07-28 6:42 Rustam Kovhaev
2020-07-28 7:11 ` Greg KH
2020-07-28 20:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a42328b6-6d45-577f-f605-337b91c19f1a@web.de \
--to=markus.elfring@web.de \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rkovhaev@gmail.com \
--cc=syzbot+67b2bd0e34f952d0321e@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).