Re: [PATCH v4 3/3] usb: dwc3: Pass quirk as platform data

[Tejas Joglekar <Tejas.Joglekar@synopsys.com>]

Hi,
On 10/14/2020 2:07 PM, Sergei Shtylyov wrote:
> Hello!
> 
> On 13.10.2020 15:44, Tejas Joglekar wrote:
> 
>> This commit adds the platform device data to setup
>> the XHCI_SG_TRB_CACHE_SIZE_QUIRK quirk. DWC3 hosts
>> which are PCI devices does not use OF to create platform device
>> but create xhci-plat platform device runtime. So
>                                       ^ at
> 
>> this patch allow parent device to supply the quirk
> 
>    Allows.
> 
Noted.
>> through platform data.
>>
>> Signed-off-by: Tejas Joglekar <joglekar@synopsys.com>
>> ---
>>   drivers/usb/dwc3/host.c | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
>> index e195176580de..dd7c742333f7 100644
>> --- a/drivers/usb/dwc3/host.c
>> +++ b/drivers/usb/dwc3/host.c
>> @@ -11,6 +11,15 @@
>>   #include <linux/platform_device.h>
>>     #include "core.h"
>> +#include "../host/xhci-plat.h"
>> +
>> +static const struct xhci_plat_priv dwc3_pdata = {
>> +    .plat_start = NULL,
>> +    .init_quirk = NULL,
>> +    .suspend_quirk = NULL,
>> +    .resume_quirk = NULL,
> 
>    Why not rely on the compiler to fill these with zeros?
> 
Sure I will update
>> +    .quirks = XHCI_SG_TRB_CACHE_SIZE_QUIRK,
>> +};
>>     static int dwc3_host_get_irq(struct dwc3 *dwc)
>>   {
> [...]
> 
> MBR, Sergei

Thanks & Regards,
 Tejas Joglekar