From: Mike Looijmans <mike.looijmans@topic.nl>
To: Mark Brown <broonie@kernel.org>
Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
balbi@kernel.org, gregkh@linuxfoundation.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v3] usb: dwc3: Add support for VBUS power control
Date: Tue, 28 Jul 2020 09:29:39 +0200 [thread overview]
Message-ID: <a6821b3d-4034-8399-af5e-1b9de0493eac@topic.nl> (raw)
In-Reply-To: <20200727115321.GC6275@sirena.org.uk>
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands
T: +31 (0) 499 33 69 69
E: mike.looijmans@topicproducts.com
W: www.topicproducts.com
Please consider the environment before printing this e-mail
On 27-07-2020 13:53, Mark Brown wrote:
> On Mon, Jul 27, 2020 at 01:50:26PM +0200, Mike Looijmans wrote:
>>
>> Met vriendelijke groet / kind regards,
>>
>> Mike Looijmans
>> System Expert
>
> You probably want to remove your signature when replying to the list...
>
>> On 27-07-2020 12:23, Mark Brown wrote:
>>> On Sun, Jul 26, 2020 at 09:10:39AM +0200, Mike Looijmans wrote:
>
>>>> It's the 5V VBUS power for the USB "plug" that's being controlled here. It
>>>> must turned on when the controller is in "host" mode. Some boards arrange
>>>> this in hardware through the PHY, and some just don't have any control at
>>>> all and have it permanently on or off. On a board where the 5V is controlled
>>>> using a GPIO line or an I2C chip, this patch is required to make it work.
>
>>> That sounds like the driver should not be using _get_optional() then.
>
>> Making it mandatory would break most (read: all except Topic's) existing
>> boards as they won't have it in their devicetree. I'm perfectly okay with
>> that, but others might disagree.
>
> No, it wouldn't break them at all - they'd get a dummy regulator
> provided.
>
Ah, so *not* using _get_optional will yield the behaviour that I'd want. I'll
test and make a v4 patch.
next prev parent reply other threads:[~2020-07-28 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 14:25 [PATCH v3] usb: dwc3: Add support for VBUS power control Mike Looijmans
2020-07-23 7:56 ` Vincent Whitchurch
2020-07-23 11:05 ` Mark Brown
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.2698920d-90ba-4c46-abda-83e18e2093c8@emailsignatures365.codetwo.com>
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.0d2bd5fa-15cc-4b27-b94e-83614f9e5b38.ac9c2a67-d7df-4f70-81b3-db983bbfb4db@emailsignatures365.codetwo.com>
2020-07-26 7:10 ` Mike Looijmans
2020-07-27 10:23 ` Mark Brown
2020-07-27 11:50 ` Mike Looijmans
2020-07-27 11:53 ` Mark Brown
2020-07-28 7:29 ` Mike Looijmans [this message]
2020-09-07 7:44 ` Felipe Balbi
2020-09-07 7:50 ` Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6821b3d-4034-8399-af5e-1b9de0493eac@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).