linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: stf_xl@wp.pl, linux-usb@vger.kernel.org
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	Bernhard <bernhard.gebetsberger@gmx.at>,
	Michael <ZeroBeat@gmx.de>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH v2] usb: xhci: do not perform Soft Retry for some xHCI hosts
Date: Wed, 10 Feb 2021 14:53:56 +0200	[thread overview]
Message-ID: <a722793b-520d-8037-4423-8da4a294f355@linux.intel.com> (raw)
In-Reply-To: <20210210081254.33734-1-stf_xl@wp.pl>

On 10.2.2021 10.12, stf_xl@wp.pl wrote:
> From: Stanislaw Gruszka <stf_xl@wp.pl>
> 
> Since f8f80be501aa ("xhci: Use soft retry to recover faster from
> transaction errors") on some systems rt2800usb and mt7601u devices
> are unable to operate. Possible reason is that some xHCI hardware
> can not perform Soft Retry for those devices correctly.
> 
> To avoid the problem add xhci->quirks flag that restore pre f8f80be501aa
> xhci behaviour for affected xHCI controllers. Currently those are
> AMD_PROMONTORYA_4 and AMD_PROMONTORYA_2, since it was confirmed
> by the users: on those xHCI hosts issue happen and is gone after
> disabling Soft Retry.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202541
> Fixes: f8f80be501aa ("xhci: Use soft retry to recover faster from transaction errors")
> Reported-and-tested-by: Bernhard <bernhard.gebetsberger@gmx.at>
> Bisected-by: Bernhard <bernhard.gebetsberger@gmx.at>
> Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
> v1 -> v2:
> compared to previous patch:
> https://lore.kernel.org/linux-usb/20210122104342.12451-1-stf_xl@wp.pl/t/#u
> now we use xhci->quirks to disable Soft Retry (I also changed topic
> to reflect the change).
> 
>  drivers/usb/host/xhci-pci.c  | 5 +++++
>  drivers/usb/host/xhci-ring.c | 3 ++-
>  drivers/usb/host/xhci.h      | 1 +
>  3 files changed, 8 insertions(+), 1 deletion(-)
> 


Thanks.

Checkpatch complains about some minor things, I'll fix those while applying.
Will send forward after 5.12-rc1 is out, and add stable tag.

-Mathias

      reply	other threads:[~2021-02-10 12:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  8:12 [PATCH v2] usb: xhci: do not perform Soft Retry for some xHCI hosts stf_xl
2021-02-10 12:53 ` Mathias Nyman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a722793b-520d-8037-4423-8da4a294f355@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=ZeroBeat@gmx.de \
    --cc=bernhard.gebetsberger@gmx.at \
    --cc=greg@kroah.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=stf_xl@wp.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).