From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-stable <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc2: use a longer AHB idle timeout in dwc2_core_reset()
Date: Mon, 24 Jun 2019 09:41:46 +0400 [thread overview]
Message-ID: <a7647aea-b3e6-b785-8476-1851f50beff1@synopsys.com> (raw)
In-Reply-To: <20190620175022.29348-1-martin.blumenstingl@googlemail.com>
On 6/20/2019 9:51 PM, Martin Blumenstingl wrote:
> Use a 10000us AHB idle timeout in dwc2_core_reset() and make it
> consistent with the other "wait for AHB master IDLE state" ocurrences.
>
> This fixes a problem for me where dwc2 would not want to initialize when
> updating to 4.19 on a MIPS Lantiq VRX200 SoC. dwc2 worked fine with
> 4.14.
> Testing on my board shows that it takes 180us until AHB master IDLE
> state is signalled. The very old vendor driver for this SoC (ifxhcd)
> used a 1 second timeout.
> Use the same timeout that is used everywhere when polling for
> GRSTCTL_AHBIDLE instead of using a timeout that "works for one board"
> (180us in my case) to have consistent behavior across the dwc2 driver.
>
> Cc: linux-stable <stable@vger.kernel.org> # 4.19+
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
> drivers/usb/dwc2/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
> index 8b499d643461..8e41d70fd298 100644
> --- a/drivers/usb/dwc2/core.c
> +++ b/drivers/usb/dwc2/core.c
> @@ -531,7 +531,7 @@ int dwc2_core_reset(struct dwc2_hsotg *hsotg, bool skip_wait)
> }
>
> /* Wait for AHB master IDLE state */
> - if (dwc2_hsotg_wait_bit_set(hsotg, GRSTCTL, GRSTCTL_AHBIDLE, 50)) {
> + if (dwc2_hsotg_wait_bit_set(hsotg, GRSTCTL, GRSTCTL_AHBIDLE, 10000)) {
> dev_warn(hsotg->dev, "%s: HANG! AHB Idle timeout GRSTCTL GRSTCTL_AHBIDLE\n",
> __func__);
> return -EBUSY;
>
next prev parent reply other threads:[~2019-06-24 5:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 17:50 [PATCH] usb: dwc2: use a longer AHB idle timeout in dwc2_core_reset() Martin Blumenstingl
2019-06-24 5:41 ` Minas Harutyunyan [this message]
2019-07-01 17:54 ` Martin Blumenstingl
2019-07-03 9:01 ` Martin Blumenstingl
2019-07-03 11:38 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7647aea-b3e6-b785-8476-1851f50beff1@synopsys.com \
--to=minas.harutyunyan@synopsys.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).