From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7909C433E0 for ; Fri, 19 Feb 2021 08:07:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7796E64EC4 for ; Fri, 19 Feb 2021 08:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229555AbhBSIH5 (ORCPT ); Fri, 19 Feb 2021 03:07:57 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:60356 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbhBSIH4 (ORCPT ); Fri, 19 Feb 2021 03:07:56 -0500 Received: from [222.129.38.131] (helo=[192.168.1.10]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lD0oi-0002Jz-VN; Fri, 19 Feb 2021 08:07:13 +0000 To: Greg Kroah-Hartman , Mathias Nyman Cc: Kai-Heng Feng , Alan Stern , Lee Jones , peter.chen@nxp.com, USB list , LKML , Bjorn Helgaas , Linux PCI References: <20210204051850.64857-1-aaron.ma@canonical.com> <00de6927-3fa6-a9a3-2d65-2b4d4e8f0012@linux.intel.com> From: Aaron Ma Subject: Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown Message-ID: Date: Fri, 19 Feb 2021 16:07:04 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 2/11/21 8:50 PM, Greg Kroah-Hartman wrote: > On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote: >> On 9.2.2021 10.37, Greg Kroah-Hartman wrote: >>> On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote: >>>> On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma wrote: >>>>> >>>>> >>>>> On 2/5/21 12:27 PM, Kai-Heng Feng wrote: >>>>>> Can you please test the following patch, which should address the root cause: >>>>>> https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furquan@google.com/ >>>>>> >>>>>> It also helps another AMD laptop on S5: >>>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912935 >>>>>> >>>>> >>>>> No, this patch doesn't help on ThinkPad AMD platform. >>>> >>>> Thanks for the confirmation! >>>> >>>> Acked-by: Kai-Heng Feng >>> >>> Mathias, want me to take this in my tree now, or are you going to send >>> me more patches for 5.12-rc1? >>> >> >> Nothing more for 5.12-rc1 from me. >> >> Could this be a PCI quirk instead of xhci? >> Maybe there is some PCI flag for this already, haven't checked yet. >> >> We want a specific PCI device to go to PCI D3cold at PCI shutdown... > > There probably is. Kay-Heng, can you look into doing that instead? > There is no such PCI quirk, usually it calls driver to shutdown. Regards, Aaron > thanks, > > greg k-h >