Re: [PATCH 0/2] usb: typec: mux: a few improvements

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 5/26/21 5:35 PM, Heikki Krogerus wrote:
> Hi,
> 
> The first patch should be trivial cleanup, but in the second one I'm
> removing the condition that in practice forces the orientation switch
> to always have the device property named "orientation-switch". This
> change only impacts connections described with device graph since only
> in that case the callback function is supplied with the "id" parameter
> which is the first part of the condition (if the id is not supplied,
> the function also does not expect the device property to exist).
> 
> But when the connection between the connector and the switch is
> described with device graph, I don't see any need for that device
> property. Therefore let's just remove the condition and the
> requirement for the device property with it.
> 
> thanks,
> 
> Heikki Krogerus (2):
>   usb: typec: mux: Use device type instead of device name for matching
>   usb: typec: mux: Remove requirement for the "orientation-switch"
>     device property

Thanks, the series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans