From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D46C4646C for ; Tue, 25 Jun 2019 02:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36ADF205F4 for ; Tue, 25 Jun 2019 02:01:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730297AbfFYCBb (ORCPT ); Mon, 24 Jun 2019 22:01:31 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:59970 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729601AbfFYCBa (ORCPT ); Mon, 24 Jun 2019 22:01:30 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 97A1229AF7; Mon, 24 Jun 2019 22:01:26 -0400 (EDT) Date: Tue, 25 Jun 2019 12:01:24 +1000 (AEST) From: Finn Thain To: Ming Lei cc: Steffen Maier , linux-scsi@vger.kernel.org, "Martin K . Petersen" , James Bottomley , Bart Van Assche , Hannes Reinecke , Christoph Hellwig , Jim Gill , Cathy Avery , "Ewan D . Milne" , Brian King , James Smart , "Juergen E . Fischer" , Michael Schmitz , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, Dan Carpenter , Benjamin Block , Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org Subject: Re: [PATCH V5 10/16] s390: zfcp_fc: use sg helper to operate scatterlist In-Reply-To: <20190625011902.GA23777@ming.t460p> Message-ID: References: <20190618013757.22401-1-ming.lei@redhat.com> <20190618013757.22401-11-ming.lei@redhat.com> <95bfa1fb-d0eb-fc61-ecc0-001ae52a326f@linux.ibm.com> <20190625011902.GA23777@ming.t460p> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org > diff --git a/drivers/s390/scsi/zfcp_dbf.c b/drivers/s390/scsi/zfcp_dbf.c > index dccdb41bed8c..c7129f5234f0 100644 > --- a/drivers/s390/scsi/zfcp_dbf.c > +++ b/drivers/s390/scsi/zfcp_dbf.c > @@ -552,7 +552,7 @@ static u16 zfcp_dbf_san_res_cap_len_if_gpn_ft(char *tag, > if (x % (ZFCP_FC_GPN_FT_ENT_PAGE + 1)) > acc++; > else > - acc = sg_virt(++resp_entry); > + acc = sg_virt(resp_entry = sg_next(resp_entry)); Shouldn't that be, acc = sg_virt(sg_next(resp_entry)); > > last = acc->fp_flags & FC_NS_FID_LAST; > } > diff --git a/drivers/s390/scsi/zfcp_fc.c b/drivers/s390/scsi/zfcp_fc.c > index b018b61bd168..5048812ce660 100644 > --- a/drivers/s390/scsi/zfcp_fc.c > +++ b/drivers/s390/scsi/zfcp_fc.c > @@ -742,7 +742,7 @@ static int zfcp_fc_eval_gpn_ft(struct zfcp_fc_req *fc_req, > if (x % (ZFCP_FC_GPN_FT_ENT_PAGE + 1)) > acc++; > else > - acc = sg_virt(++sg); > + acc = sg_virt(sg = sg_next(sg)); and acc = sg_virt(sg_next(sg)); ? -- > > last = acc->fp_flags & FC_NS_FID_LAST; > d_id = ntoh24(acc->fp_fid); > -- > 2.20.1 > > > Thanks, > Ming >