Linux-USB Archive on
 help / color / Atom feed
From: Hans de Goede <>
To: Heikki Krogerus <>
Cc: MyungJoo Ham <>,
	Chanwoo Choi <>,
	Greg Kroah-Hartman <>,,
Subject: Re: [PATCH 0/2] extcon: axp288: Move to swnodes
Date: Sun, 6 Oct 2019 21:37:25 +0200
Message-ID: <> (raw)
In-Reply-To: <>


On 01-10-2019 12:51, Heikki Krogerus wrote:
> Hi Hans,
> That AXP288 extcon driver is the last that uses build-in connection
> description. I'm replacing it with a code that finds the role mux
> software node instead.
> I'm proposing also here a little helper
> usb_role_switch_find_by_fwnode() that uses
> class_find_device_by_fwnode() to find the role switches.

I'm building a kernel with these patches to test them now
(on hw which uses the axp288 extcon code-paths with the role-sw)

No test results yet, but I did notice this will building:

   CC [M]  drivers/extcon/extcon-axp288.o
drivers/extcon/extcon-axp288.c: In function ‘axp288_extcon_find_role_sw’:
drivers/extcon/extcon-axp288.c:333:9: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   333 |  swnode = software_node_find_by_name(NULL, "intel-xhci-usb-sw");
       |         ^



  parent reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 10:51 Heikki Krogerus
2019-10-01 10:51 ` [PATCH 1/2] usb: roles: Add usb_role_switch_find_by_fwnode() Heikki Krogerus
2019-10-01 10:51 ` [PATCH 2/2] extcon: axp288: Remove the build-in connection description Heikki Krogerus
2019-10-06 19:37 ` Hans de Goede [this message]
2019-10-08 11:15   ` [PATCH 0/2] extcon: axp288: Move to swnodes Heikki Krogerus

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on

Archives are clonable:
	git clone --mirror linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ \
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone