linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars Melin <larsm17@gmail.com>
To: Zhengjun Zhang <zhangzhengjun@aicrobo.com>, johan@kernel.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH] Add new VID/PID to support Fibocom FG150 5G module
Date: Sun, 8 Aug 2021 20:41:10 +0700	[thread overview]
Message-ID: <b3285ae0-8b1f-fc9c-3662-634264d704d5@gmail.com> (raw)
In-Reply-To: <20210807151144.11227-1-zhangzhengjun@aicrobo.com>

On 8/7/2021 22:11, Zhengjun Zhang wrote:
> Fibocom FG150 is a 5G module based on Qualcomm SDX55 platform,
> support Sub-6G band.

> +/* Fibocom products */
> +#define FIBOCOM_VENDOR_ID			0x2cb7
> +#define FIBOCOM_PRODUCT_FG150			0x010b
>   
>   /* Device flags */
>   
> @@ -2077,6 +2080,8 @@ static const struct usb_device_id option_ids[] = {
>   	{ USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1404, 0xff) },			/* GosunCn GM500 RNDIS */
>   	{ USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1405, 0xff) },			/* GosunCn GM500 MBIM */
>   	{ USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1406, 0xff) },			/* GosunCn GM500 ECM/NCM */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(FIBOCOM_VENDOR_ID, FIBOCOM_PRODUCT_FG150, 0xff, 0xff, 0x30) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(FIBOCOM_VENDOR_ID, FIBOCOM_PRODUCT_FG150, 0xff, 0, 0) },
>   	{ } /* Terminating entry */
>   };
>   MODULE_DEVICE_TABLE(usb, option_ids); >

Please don't do the defines for Fibocom VID and PID, just add them by 
their numerical value after 2cb7:0105 in the
MODULE_DEVICE_TABLE.

thanks
Lars

  reply	other threads:[~2021-08-08 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-07 15:11 Zhengjun Zhang
2021-08-08 13:41 ` Lars Melin [this message]
2021-08-09 13:35   ` [PATCH v2] USB: serial: option: add new VID/PID to support Fibocom FG150 Zhengjun Zhang
2021-08-24 13:45     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3285ae0-8b1f-fc9c-3662-634264d704d5@gmail.com \
    --to=larsm17@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=zhangzhengjun@aicrobo.com \
    --subject='Re: [PATCH] Add new VID/PID to support Fibocom FG150 5G module' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).