From: shuah <shuah@kernel.org>
To: Suwan Kim <suwan.kim027@gmail.com>
Cc: valentina.manea.m@gmail.com, gregkh@linuxfoundation.org,
stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, shuah <shuah@kernel.org>
Subject: Re: [PATCH v4 1/2] usbip: Skip DMA mapping and unmapping for urb at vhci
Date: Tue, 6 Aug 2019 09:38:54 -0600 [thread overview]
Message-ID: <b5c6c9e5-0855-c055-6bb5-47dbc497f606@kernel.org> (raw)
In-Reply-To: <20190806153241.GA3738@localhost.localdomain>
On 8/6/19 9:32 AM, Suwan Kim wrote:
> On Tue, Aug 06, 2019 at 09:11:30AM -0600, shuah wrote:
>> On 8/6/19 6:31 AM, Suwan Kim wrote:
>>> vhci doesn’t do DMA for remote device. Actually, the real DMA
>>> operation is done by network card driver. vhci just passes virtual
>>> address of the buffer to the network stack, so vhci doesn’t use and
>>> need dma address of the buffer of the URB.
>>>
>>> But HCD provides DMA mapping and unmapping function by default.
>>> Moreover, it causes unnecessary DMA mapping and unmapping which
>>> will be done again at the NIC driver and it wastes CPU cycles.
>>> So, implement map_urb_for_dma and unmap_urb_for_dma function for
>>> vhci in order to skip the DMA mapping and unmapping procedure.
>>>
>>> When it comes to supporting SG for vhci, it is useful to use native
>>> SG list (urb->num_sgs) instead of mapped SG list because DMA mapping
>>> fnuction can adjust the number of SG list (urb->num_mapped_sgs).
>>> And vhci_map_urb_for_dma() prevents isoc pipe from using SG as
>>> hcd_map_urb_for_dma() does.
>>>
>>> Signed-off-by: Suwan Kim <suwan.kim027@gmail.com>
>>> ---
>>> v3 - v4:
>>> - Replace WARN_ON() with pr_err() in the error path.
>>>
>>> v2 - v3
>>> - Move setting URB_DMA_MAP_SG flag to the patch 2.
>>> - Prevent isoc pipe from using SG buffer.
>>>
>>> v1 - v2
>>> - Add setting URB_DMA_MAP_SG flag in urb->transfer_flags to tell
>>> stub driver to use SG buffer.
>>> ---
>>> drivers/usb/usbip/vhci_hcd.c | 19 +++++++++++++++++++
>>> 1 file changed, 19 insertions(+)
>>>
>>> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
>>> index 000ab7225717..429e4e989f38 100644
>>> --- a/drivers/usb/usbip/vhci_hcd.c
>>> +++ b/drivers/usb/usbip/vhci_hcd.c
>>> @@ -1288,6 +1288,22 @@ static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev,
>>> return 0;
>>> }
>>> +static int vhci_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
>>> + gfp_t mem_flags)
>>> +{
>>> + if (usb_endpoint_xfer_isoc(&urb->ep->desc) && urb->num_sgs) {
>>> + pr_err("SG is not supported for isochronous transfer\n");
>>
>> Any reason to not use dev_err()?
>
> Because some codes in vhci_hcd.c use pr_err().There is no other
> reason. However, dev_err() seems more appropriate than pr_err().
> I will replace pr_err() with dev_err(urb->dev->dev, "SG is ...")
> Is it ok?
>
Please. This way we will have the device information. pr_err()
won't us that. In general I prefer dev_* if dev is available in
the code path, which is the case here.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-08-06 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 12:31 [PATCH v4 0/2] usbip: Implement SG support Suwan Kim
2019-08-06 12:31 ` [PATCH v4 1/2] usbip: Skip DMA mapping and unmapping for urb at vhci Suwan Kim
2019-08-06 15:11 ` shuah
2019-08-06 15:32 ` Suwan Kim
2019-08-06 15:38 ` shuah [this message]
2019-08-06 15:52 ` Suwan Kim
2019-08-06 12:31 ` [PATCH v4 2/2] usbip: Implement SG support to vhci-hcd and stub driver Suwan Kim
2019-08-06 15:13 ` shuah
2019-08-06 15:48 ` Suwan Kim
2019-08-06 17:27 ` shuah
2019-08-08 14:21 ` Suwan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5c6c9e5-0855-c055-6bb5-47dbc497f606@kernel.org \
--to=shuah@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=suwan.kim027@gmail.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).