From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>, mathias.nyman@intel.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xhci: Remove CONFIG_USB_DEFAULT_PERSIST to prevent xHCI from runtime suspending
Date: Wed, 1 Dec 2021 11:01:33 +0200 [thread overview]
Message-ID: <b7595524-1041-8b8b-dc61-9ee0acbc8307@linux.intel.com> (raw)
In-Reply-To: <CAAd53p4CpEQR0Y5XDN5E7xZ-iw2GG=gGMSm2Vd=V_M1LLEuuCA@mail.gmail.com>
On 1.12.2021 2.19, Kai-Heng Feng wrote:
> On Fri, Nov 19, 2021 at 5:27 PM Kai-Heng Feng
> <kai.heng.feng@canonical.com> wrote:
>>
>> When the xHCI is quirked with XHCI_RESET_ON_RESUME, runtime resume
>> routine also resets the controller.
>>
>> This is bad for USB drivers without reset_resume callback, because
>> there's no subsequent call of usb_dev_complete() ->
>> usb_resume_complete() to force rebinding the driver to the device. For
>> instance, btusb device stops working after xHCI controller is runtime
>> resumed, if the controlled is quirked with XHCI_RESET_ON_RESUME.
>>
>> So always take XHCI_RESET_ON_RESUME into account to solve the issue.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> A gentle ping...
Thanks
Adding to queue
-Mathias
next prev parent reply other threads:[~2021-12-01 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 9:26 [PATCH] xhci: Remove CONFIG_USB_DEFAULT_PERSIST to prevent xHCI from runtime suspending Kai-Heng Feng
2021-12-01 0:19 ` Kai-Heng Feng
2021-12-01 9:01 ` Mathias Nyman [this message]
2021-12-09 6:42 ` Kai-Heng Feng
2021-12-10 14:22 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7595524-1041-8b8b-dc61-9ee0acbc8307@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).