From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
Artur Petrosyan <Arthur.Petrosyan@synopsys.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] usb: dwc2: Skip clock gating on Samsung SoCs
Date: Fri, 16 Jul 2021 11:12:16 +0200 [thread overview]
Message-ID: <bb750c51-c01a-fb95-4ad5-2fd3f1c625f9@canonical.com> (raw)
In-Reply-To: <6fb5313e-b2c0-7b3e-84f7-6333216f4292@synopsys.com>
On 16/07/2021 11:07, Minas Harutyunyan wrote:
> Hi Krzysztof,
>
> On 7/16/2021 12:10 PM, Krzysztof Kozlowski wrote:
>> On 16/07/2021 07:01, Marek Szyprowski wrote:
>>> Commit 0112b7ce68ea ("usb: dwc2: Update dwc2_handle_usb_suspend_intr
>>> function.") changed the way the driver handles power down modes in a such
>>> way that it uses clock gating when no other power down mode is available.
>>>
>>> This however doesn't work well on the DWC2 implementation used on the
>>> Samsung SoCs. When a clock gating is enabled, system hangs. It looks that
>>> the proper clock gating requires some additional glue code in the shared
>>> USB2 PHY and/or Samsung glue code for the DWC2. To restore driver
>>> operation on the Samsung SoCs simply skip enabling clock gating mode
>>> until one finds what is really needed to make it working reliably.
>>>
>>> Fixes: 0112b7ce68ea ("usb: dwc2: Update dwc2_handle_usb_suspend_intr function.")
>>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> ---
>>> drivers/usb/dwc2/core.h | 4 ++++
>>> drivers/usb/dwc2/core_intr.c | 3 ++-
>>> drivers/usb/dwc2/hcd.c | 6 ++++--
>>> drivers/usb/dwc2/params.c | 1 +
>>> 4 files changed, 11 insertions(+), 3 deletions(-)
>>>
>>
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>
> What mean your "Acked-by" tag? Do you want to mention that this commit
> "Tested-by" or "Reviewed-by" by you?
My "Acked-by" means exactly what Linux process defines:
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L426
Acked-by is neither Tested-by nor Reviewed-by. For the definition
of these other tags, please also see link above.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-07-16 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210716050132eucas1p285949f9a73764b173c29ad0fa8502f23@eucas1p2.samsung.com>
2021-07-16 5:01 ` [PATCH] usb: dwc2: Skip clock gating on Samsung SoCs Marek Szyprowski
2021-07-16 8:10 ` Krzysztof Kozlowski
2021-07-16 9:07 ` Minas Harutyunyan
2021-07-16 9:12 ` Krzysztof Kozlowski [this message]
2021-07-16 14:54 ` Minas Harutyunyan
2021-08-03 9:40 ` Marek Szyprowski
2021-08-03 10:08 ` Minas Harutyunyan
2021-08-04 11:29 ` Marek Szyprowski
2021-08-04 17:19 ` Minas Harutyunyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb750c51-c01a-fb95-4ad5-2fd3f1c625f9@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=Arthur.Petrosyan@synopsys.com \
--cc=Minas.Harutyunyan@synopsys.com \
--cc=b.zolnierkie@samsung.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).