From: <Nicolas.Ferre@microchip.com>
To: <natechancellor@gmail.com>, <stern@rowland.harvard.edu>,
<gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: host: ohci-at91: Remove unused variable regs in at91_stop_hc
Date: Mon, 14 Oct 2019 08:07:03 +0000 [thread overview]
Message-ID: <bff9bdd9-bc3c-e333-7b4a-df53194de06f@microchip.com> (raw)
In-Reply-To: <20191011185950.1470-1-natechancellor@gmail.com>
On 11/10/2019 at 20:59, Nathan Chancellor wrote:
> drivers/usb/host/ohci-at91.c:118:28: warning: unused variable 'regs'
> [-Wunused-variable]
> struct ohci_regs __iomem *regs = hcd->regs;
> ^
> 1 warning generated.
>
> Fixes: 9c4567fa0a44 ("USB: host: ohci-at91: completely shutdown the controller in at91_stop_hc()")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/usb/host/ohci-at91.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index 513e48397743..b635c6a1b1a9 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -115,7 +115,6 @@ static void at91_start_hc(struct platform_device *pdev)
> static void at91_stop_hc(struct platform_device *pdev)
> {
> struct usb_hcd *hcd = platform_get_drvdata(pdev);
> - struct ohci_regs __iomem *regs = hcd->regs;
> struct ohci_at91_priv *ohci_at91 = hcd_to_ohci_at91_priv(hcd);
>
> dev_dbg(&pdev->dev, "stop\n");
>
--
Nicolas Ferre
prev parent reply other threads:[~2019-10-14 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 18:59 [PATCH] USB: host: ohci-at91: Remove unused variable regs in at91_stop_hc Nathan Chancellor
2019-10-14 8:07 ` Nicolas.Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bff9bdd9-bc3c-e333-7b4a-df53194de06f@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).