[Bug 214131] New: ch341 communication problem

[Bug 214131] New: ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

            Bug ID: 214131
           Summary: ch341 communication problem
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.14-rc5
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: USB
          Assignee: drivers_usb@kernel-bugs.kernel.org
          Reporter: pb.g@gmx.de
        Regression: No

Created attachment 298411
  --> https://bugzilla.kernel.org/attachment.cgi?id=298411&action=edit
captured communication

Several users reported their USB-Serial Adapter based on ch341 driver does not
communicate correctly anymore with kernels somewhere above 5.10.56-1.  

The problem is that flashing an ESP8266 board is not possible anymore with
Arduino IDE resulting in a 

"/dev/ttyUSB0 failed to connect: Failed to connect to ESP8266: Timed out
waiting for packet header"

error.

I can confirm this issue up to kernel 5.14-rc5. 
Downgrading my kernel to 5.10.52 also solves the problem.

I attached two communication samples from github user jypma.

The issue is was discussed here:
https://github.com/espressif/esptool/issues/653

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

loqs (kernel_bugzilla@entropy-collector.net) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kernel_bugzilla@entropy-col
                   |                            |lector.net

--- Comment #1 from loqs (kernel_bugzilla@entropy-collector.net) ---
What if you revert 3c18e9baee0ef97510dcda78c82285f52626764b
which was back-ported to 5.10-58 and 5.13.10?

I believe it is the same bug as discussed here
https://bugs.archlinux.org/task/71830

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

--- Comment #2 from Paul Größel (pb.g@gmx.de) ---
Indeed, removing 

.bulk_in_size      = 512,

and recompiling my 5.13.10 kernel solved the issue.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

--- Comment #3 from Johan Hovold (johan@kernel.org) ---
Thanks for reporting and tracking down the commit that caused the
regression.

Could you be a bit more specific about the symptoms here? Judging from a
quick look at the github thread, it appears that the device is still
working although timing may have changes slightly. The arch thread
indicates that the device doesn't even enumerate, which does not seem to
be the case here.

Also please provide the output of "lsusb -v" for this device.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

--- Comment #4 from Paul Größel (pb.g@gmx.de) ---
Created attachment 298433
  --> https://bugzilla.kernel.org/attachment.cgi?id=298433&action=edit
lsusb -v

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

--- Comment #5 from Paul Größel (pb.g@gmx.de) ---
I agree, I couldn't find any enumerate related symptoms here:

dmesg:

[ 7572.641499] usb 3-3.4: new full-speed USB device number 7 using xhci_hcd
[ 7572.731906] usb 3-3.4: New USB device found, idVendor=1a86, idProduct=7523,
bcdDevice= 2.63
[ 7572.731910] usb 3-3.4: New USB device strings: Mfr=0, Product=2,
SerialNumber=0
[ 7572.731912] usb 3-3.4: Product: USB2.0-Serial
[ 7572.788929] ch341 3-3.4:1.0: ch341-uart converter detected
[ 7572.802958] usb 3-3.4: ch341-uart converter now attached to ttyUSB0

lsusb -v see attachment above

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 214131] ch341 communication problem

[Johan Hovold]

On Mon, Aug 23, 2021 at 09:14:49AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=214131
> 
> --- Comment #5 from Paul Größel (pb.g@gmx.de) ---
> I agree, I couldn't find any enumerate related symptoms here:

I was able to reproduce the problem here. The device doesn't send a
zero-length package in case the received data is a multiple of the
endpoint size so that the bulk transfer doesn't complete (e.g. your
flashing application may not receive replies).

We need to revert the offending commit until we can figure out how to
configure the device to send ZLPs.

Thanks again for reporting this, and sorry about the breakage.

Johan

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

--- Comment #7 from Johan Hovold (johan@kernel.org) ---
On Mon, Aug 23, 2021 at 09:14:49AM +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=214131
> 
> --- Comment #5 from Paul Größel (pb.g@gmx.de) ---
> I agree, I couldn't find any enumerate related symptoms here:

I was able to reproduce the problem here. The device doesn't send a
zero-length package in case the received data is a multiple of the
endpoint size so that the bulk transfer doesn't complete (e.g. your
flashing application may not receive replies).

We need to revert the offending commit until we can figure out how to
configure the device to send ZLPs.

Thanks again for reporting this, and sorry about the breakage.

Johan

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

--- Comment #8 from Johan Hovold (johan@kernel.org) ---
For the record, I've applied the revert now and it should be backported
to the stable trees shortly:

       
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=df7b16d1c00ecb3da3a30c999cdb39f273c99a2f

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

Bogusław Brandys (brandys@o2.pl) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brandys@o2.pl

--- Comment #9 from Bogusław Brandys (brandys@o2.pl) ---
5.4.0-88-generic #99-Ubuntu SMP Thu Sep 23 17:29:00 UTC 2021 x86_64 x86_64
x86_64 GNU/Linux

Ubuntu 20.04.3 LTS

problem with ch341 driver re-appeared while in 5.4.0.-86 is working fine.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 214131] ch341 communication problem

[Johan Hovold]

On Mon, Oct 04, 2021 at 09:21:09AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:

> --- Comment #9 from Bogusław Brandys (brandys@o2.pl) ---
> 5.4.0-88-generic #99-Ubuntu SMP Thu Sep 23 17:29:00 UTC 2021 x86_64 x86_64
> x86_64 GNU/Linux
> 
> Ubuntu 20.04.3 LTS
> 
> problem with ch341 driver re-appeared while in 5.4.0.-86 is working fine.

This issue has been fixed in mainline (and stable), but we have no idea
what Ubuntu puts in their kernels. Please report it them. 

Johan

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

--- Comment #11 from Johan Hovold (johan@kernel.org) ---
On Mon, Oct 04, 2021 at 09:21:09AM +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:

> --- Comment #9 from Bogusław Brandys (brandys@o2.pl) ---
> 5.4.0-88-generic #99-Ubuntu SMP Thu Sep 23 17:29:00 UTC 2021 x86_64 x86_64
> x86_64 GNU/Linux
> 
> Ubuntu 20.04.3 LTS
> 
> problem with ch341 driver re-appeared while in 5.4.0.-86 is working fine.

This issue has been fixed in mainline (and stable), but we have no idea
what Ubuntu puts in their kernels. Please report it them. 

Johan

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214131] ch341 communication problem

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214131

Johan Hovold (johan@kernel.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |johan@kernel.org
         Resolution|---                         |CODE_FIX
           Assignee|drivers_usb@kernel-bugs.ker |johan@kernel.org
                   |nel.org                     |

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.