[Bug 214259] New: Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[Bug 214259] New: Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

            Bug ID: 214259
           Summary: Discrete Thunderbold Controller 8086:1137 throws DMAR
                    and XHCI errors and is only partially functional
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.13.12 and 5.14-rc7
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: USB
          Assignee: drivers_usb@kernel-bugs.kernel.org
          Reporter: wse@tuxedocomputers.com
        Regression: No

Affected devices: Clevo X170KM Barebone (I have one here) and according to this
reddit thread that describes the exact same problem a Thunderbold PCIe
exapansion card:
https://www.reddit.com/r/Thunderbolt/comments/ohjakr/asus_thunderboltex_4_linux_compatability/

The Clevo does not use the build in thunderbold controler of the CPU but a
discrete Thunderbold controler, which seems to be the exact same one from that
expansion card with the pci id of 8086:1137.

High level problem desciption: I have Thunderbold dock with DP-out, USB ports
and an Ethernet port. When I plug it in, only the DP port works. When its
plugged in before boot, ethernet also works. The USB ports on the Dock never
work.

dmesg is showing several erros regarding DMAR and xhci, since the DMAR errors
are shwing up first is suspect them to be the root cause making the rest
afterwards fails also.

The error is slightly different between 5.13 and 5.14

5.14-rc7:
[    3.148557] DMAR: DRHD: handling fault status reg 2
[    3.148561] DMAR: [DMA Write NO_PASID] Request device [0x04:0x00.0] fault
addr 0x69974000 [fault reason 0x05] PTE Write access is not set

5.13.12:
[    3.737783] DMAR: DRHD: handling fault status reg 2
[    3.737790] DMAR: [DMA Write] Request device [04:00.0] PASID ffffffff fault
addr 69974000 [fault reason 05] PTE Write access is not set

04.00.0 is the thunderbold controller:
04:00.0 USB controller [0c03]: Intel Corporation Thunderbolt 4 NHI [Maple Ridge
4C 2020] [8086:1137] (prog-if 40 [USB4 Host Interface])

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #1 from wse@tuxedocomputers.com ---
Created attachment 298567
  --> https://bugzilla.kernel.org/attachment.cgi?id=298567&action=edit
dmsg of boot without tb dock connected

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #2 from wse@tuxedocomputers.com ---
Created attachment 298569
  --> https://bugzilla.kernel.org/attachment.cgi?id=298569&action=edit
dmsg after connecting tb dock

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #3 from wse@tuxedocomputers.com ---
Created attachment 298571
  --> https://bugzilla.kernel.org/attachment.cgi?id=298571&action=edit
dmsg of boot with tb dock connected

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #4 from wse@tuxedocomputers.com ---
Created attachment 298573
  --> https://bugzilla.kernel.org/attachment.cgi?id=298573&action=edit
lspci of boot without tb dock connected

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #5 from wse@tuxedocomputers.com ---
Created attachment 298575
  --> https://bugzilla.kernel.org/attachment.cgi?id=298575&action=edit
lspci after connecting tb dock

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #6 from wse@tuxedocomputers.com ---
Created attachment 298577
  --> https://bugzilla.kernel.org/attachment.cgi?id=298577&action=edit
lspci of boot with tb dock connected

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #7 from wse@tuxedocomputers.com ---
These logs are all for kernel 5.14-rc7

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #8 from wse@tuxedocomputers.com ---
Created attachment 298579
  --> https://bugzilla.kernel.org/attachment.cgi?id=298579&action=edit
dmsg of boot without tb dock connected (5.13.12)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #9 from wse@tuxedocomputers.com ---
Created attachment 298581
  --> https://bugzilla.kernel.org/attachment.cgi?id=298581&action=edit
dmsg after connecting tb dock (5.13.12)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #10 from wse@tuxedocomputers.com ---
Created attachment 298583
  --> https://bugzilla.kernel.org/attachment.cgi?id=298583&action=edit
dmsg of boot with tb dock connected (5.13.12)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #11 from wse@tuxedocomputers.com ---
Created attachment 298585
  --> https://bugzilla.kernel.org/attachment.cgi?id=298585&action=edit
lspci of boot without tb dock connected (5.13.12)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #12 from wse@tuxedocomputers.com ---
Created attachment 298587
  --> https://bugzilla.kernel.org/attachment.cgi?id=298587&action=edit
lspci after connecting tb dock (5.13.12)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #13 from wse@tuxedocomputers.com ---
Created attachment 298589
  --> https://bugzilla.kernel.org/attachment.cgi?id=298589&action=edit
lspci of boot with tb dock connected (5.13.12)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #14 from wse@tuxedocomputers.com ---
New info: The intel_iommu=off boot flag makes the DMAR errors go away. However
xhci errors stay and the USB ports of the dock are still disfunctional.
So they are seperate issues after all.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #15 from wse@tuxedocomputers.com ---
For reference: A reddit thread discussing the descrete Asus thunderbolt pcie
card failing in the exact same way:
https://www.reddit.com/r/Thunderbolt/comments/ohjakr/asus_thunderboltex_4_linux_compatability/

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #16 from wse@tuxedocomputers.com ---
Found a preexisteng hack originally for tb3 fixing the issue also on this tb4
controller: https://bugzilla.kernel.org/show_bug.cgi?id=206459#c59

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

wse@tuxedocomputers.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #17 from wse@tuxedocomputers.com ---


*** This bug has been marked as a duplicate of bug 206459 ***

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

Hans de Goede (jwrdegoede@fedoraproject.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwrdegoede@fedoraproject.or
                   |                            |g

--- Comment #18 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Thank you for your bug report.

I've prepared a patch series fixing bug 206459 as well as this bug:

https://lore.kernel.org/linux-pci/20220519152150.6135-1-hdegoede@redhat.com/T/#t

This series is using DMI matching to identify affected systems and to enable
the workaround only on affected systems.

I've used DMI_MATCH(DMI_BOARD_NAME, "X170KM-G") as match for this Clevo
Barebone.

Can you confirm that:

cat /sys/class/dmi/id/board_name

outputs "X170KM-G" ?

Or even better, give this patch series a try ? Note the series is based on top
of:
https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/resource

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #19 from wse@tuxedocomputers.com ---
Thank you for the patch.

Yes, "X170KM-G" is the exact match for /sys/class/dmi/id/board_name on the
affected device.

Kernel with patch series is compiling atm. Will add another post wether or not
it worked.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #20 from wse@tuxedocomputers.com ---
Successfully tested the patchset: Works like a charm.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

Konrad J Hambrick (kjhambrick@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kjhambrick@gmail.com

--- Comment #21 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Hans --

I have exactly the same Hardware and when I Enable my Discrete ThunderBolt in
the BIOS, I experience a series of TimeOut delays during Boot.

I am running 5.15.53 on Slackware64 15.0 ...

I don't have a Dock for my LapTop so I am not sure this bug is a duplicate of
https://bugzilla.kernel.org/show_bug.cgi?id=206459

Q1: Is your Patch Series still viable ?

If so, your second link above for the patch series no longer works:  
https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/resource

Q2:  Was this patch ever included in the kernel source tree ?

If so, what version should I try ?

Thanks !

-- kjh

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #22 from Konrad J Hambrick (kjhambrick@gmail.com) ---
(In reply to Konrad J Hambrick from comment #21)
> Hans --
> 
> I have exactly the same Hardware and when I Enable my Discrete ThunderBolt
> in the BIOS, I experience a series of TimeOut delays during Boot.
> 
> I am running 5.15.53 on Slackware64 15.0 ...
> 
> I don't have a Dock for my LapTop so I am not sure this bug is a duplicate
> of https://bugzilla.kernel.org/show_bug.cgi?id=206459
> 
> Q1: Is your Patch Series still viable ?
> 
> If so, your second link above for the patch series no longer works:  
> https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/
> resource
> 
> Q2:  Was this patch ever included in the kernel source tree ?
> 
> If so, what version should I try ?
> 
> Thanks !
> 
> -- kjh

p.s. this is my dmesg with the Discrete Thunderbolt Enabled:

[    9.359600] input: SynPS/2 Synaptics TouchPad as
/devices/platform/i8042/serio2/input/input15
[   27.953327] DMAR: DRHD: handling fault status reg 2
[   27.959653] DMAR: [DMA Write NO_PASID] Request device [07:00.0] fault addr
0x69935000 [fault reason 0x05] PTE Write access is not set
[   48.433330] DMAR: DRHD: handling fault status reg 2
[   48.438777] DMAR: [DMA Write NO_PASID] Request device [07:00.0] fault addr
0x69935000 [fault reason 0x05] PTE Write access is not set
[   68.913306] DMAR: DRHD: handling fault status reg 2
[   68.919850] DMAR: [DMA Write NO_PASID] Request device [07:00.0] fault addr
0x69935000 [fault reason 0x05] PTE Write access is not set
[   89.387726] thunderbolt 0000:07:00.0: failed to send driver ready to ICM
[   89.394835] thunderbolt: probe of 0000:07:00.0 failed with error -110

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #23 from wse@tuxedocomputers.com ---
(In reply to Konrad J Hambrick from comment #21)
> Hans --
> 
> I have exactly the same Hardware and when I Enable my Discrete ThunderBolt
> in the BIOS, I experience a series of TimeOut delays during Boot.
> 
> I am running 5.15.53 on Slackware64 15.0 ...
> 
> I don't have a Dock for my LapTop so I am not sure this bug is a duplicate
> of https://bugzilla.kernel.org/show_bug.cgi?id=206459
> 
> Q1: Is your Patch Series still viable ?
> 
> If so, your second link above for the patch series no longer works:  
> https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/
> resource
> 
> Q2:  Was this patch ever included in the kernel source tree ?
> 
> If so, what version should I try ?
> 
> Thanks !
> 
> -- kjh

The series got merged in mainline:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?qt=grep&q=Add+kernel+cmdline+options+to+use%2Fignore+E820+reserved+regions

the kernel.org cgit is always a good option to search if a patch got applied in
the end

Also don't forget to check linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?qt=grep&q=Add+kernel+cmdline+options+to+use%2Fignore+E820+reserved+regions

or subsystem specific branches like drm-tip (on the fredesktop cgit:
https://cgit.freedesktop.org/)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #24 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Thanks for the info and the tip, wse !

-- kjh

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

Bjorn Helgaas (bjorn@helgaas.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bjorn@helgaas.com

--- Comment #25 from Bjorn Helgaas (bjorn@helgaas.com) ---
I don't know the connection to the DMAR faults, but from the first log
(https://bugzilla.kernel.org/attachment.cgi?id=298567):

  BIOS-e820: [mem 0x000000006bc00000-0x00000000efffffff] reserved
  pci_bus 0000:00: root bus resource [mem 0x71000000-0xdfffffff window]

This entire PCI host bridge aperture is "reserved" in the E820 map, which means
we won't allocate any PCI BARs in that area, which means hot-add won't work.

The current workaround for this is https://git.kernel.org/linus/d341838d776a
("x86/PCI: Disable E820 reserved region clipping via quirks"), which appeared
in v5.19.

I think the underlying issue is that this machine has EFI, Linux converts the
EFI memory map to E820 format, and it converts EFI_MEMORY_MAPPED_IO to
E820_TYPE_RESERVED.  EFI_MEMORY_MAPPED_IO means "the OS must map this memory
for use by EFI runtime services."  It does *not* mean "the OS can never use
this memory."  I think Linux should omit EFI_MEMORY_MAPPED_IO areas completely
from the E820 map.

This is basically the same issue as bug #216565.  I attached a patch there to
omit EFI_MEMORY_MAPPED_IO.

I would love to hear from anybody with a Clevo machine that shows similar
problems.  If you can, please boot with the patch at
https://bugzilla.kernel.org/attachment.cgi?id=303123 with the "efi=debug"
kernel parameter, open new bugzilla with the complete dmesg log, and assign it
to me.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #26 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Bjorn --

The referenced efi_mmio-2 Patch applied cleanly on 5.15.77 and I am building a
5.15.77_bjorn_p Kernel now.

I'll have to wait until after work to install and boot but I'll enable Discrete
Thunderbolt in my Insyde EFI Bios and boot 5.15.bjorn_p

Thank You !

-- kjh

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #27 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Created attachment 303131
  --> https://bugzilla.kernel.org/attachment.cgi?id=303131&action=edit
Linux 5.15.77 with Discrete Thunderbolt Enabled ( no patch )

Bjorn --

This dmesg for linux 5.15.77 without your Patch.

When I enable 'Discrete Thunderbolt' in the Insyde BIOS there is a long delay
for each of the three DMAR Errors and a final delay for Thunderbolt ( see time
stamp: [11.534560] thru [88.380241]

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #28 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Created attachment 303132
  --> https://bugzilla.kernel.org/attachment.cgi?id=303132&action=edit
This is 5.15.77 with your patch applied

This is linux 5.15.77 with your patch applied.

There are extra log entries before event 'do_add_efi_memmap' at timestamp
[0.000000]

The same three DMAR faults and timeouts still happen between timestamps
[26.938364] and [88.372760] and there is still a Discrete Thunderbold error at
[88.378716]

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #29 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Created attachment 303133
  --> https://bugzilla.kernel.org/attachment.cgi?id=303133&action=edit
Linux 5.15.77 with Discrete Thunderbolt ( no patch )

Bjorn --

For reference, this is dmesg for 5.15.77 with Discrete Thunderbolt disabled and
without your Patch

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #30 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Created attachment 303134
  --> https://bugzilla.kernel.org/attachment.cgi?id=303134&action=edit
5.15.77 with your Patch with Discrete Thunderbolt Disabled

And again for reference, this is 5.15.77 with your patch with Discrete
Thunderbolt Disabled in the INSYDE BIOS

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #31 from Bjorn Helgaas (bjorn@helgaas.com) ---
Thank you very much for all this work, Konrad!

I'm confused.  Comments #16 and #17 suggest that this DMAR issue was fixed by
https://git.kernel.org/linus/d341838d776a ("x86/PCI: Disable E820 reserved
region clipping via quirks"), which appeared in v5.19.  Can you confirm that?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #32 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Bjorn --

You're welcome.  

I was unable to successfully apply those patches against 5.15.y and then I
believe the patches were reverted or partially reverted in 5.19.y.

I will consider running a newer Long-Term Kernel when it is announced next
month, especially if it fixes Discrete Thunderbolt and especially since 5.15.y
will go EoL in Oct 2023.

Thanks for all you do for the Linux Kernel, Bjorn !

-- kjh

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #33 from wse@tuxedocomputers.com ---
I think the long delay is a different issue then the e820 region patch and has
more to do with this:

[   88.372827] thunderbolt 0000:07:00.0: failed to send driver ready to ICM

the 20s delay between the 4 retries come from this:

https://elixir.bootlin.com/linux/latest/source/drivers/thunderbolt/icm.c#L1024

or this

https://elixir.bootlin.com/linux/latest/source/drivers/thunderbolt/icm.c#L1630

respecifly.

Having the icm not correctly initialized seems to be no problem however? I read
somewhere that there is a software fallback for it. But I don't really know
what the icm actually does in the first place xD.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #34 from wse@tuxedocomputers.com ---
But I think we should propably open another bugreport for this.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #35 from wse@tuxedocomputers.com ---
For reference: what fixed the Clevo X170KM for me exept the delay was this
patch series:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa6dae5d82081e8d9f8e6a2baf7149442a6c1ba5

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d341838d776abadb3ac48abdd2f1f40df5a4fc10

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0ae084d5a6744b1318407d8e20fb88ac0fd85d47

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #36 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Thanks for all the info wse@tuxedocomputers.com

The comments in Hans de Goede's three patches look familiar but I'll try all
three patches against 5.15.y again.

Or should I be running a different Kernel Version ?

The Code referenced at elixir.bootlin.com is from Kernel Version 6.0.7 ...

I'll test next weekend when I've got time to build ; boot ; dmesg ; repeat 

Then I will open a new bug report.

Thank you and thank you and Tuxedo Computers for the tuxedo-keyboard-master and
tuxedo-keyboard-ite kernel modules ( they work great for me ) !

-- kjh

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

Bjorn Helgaas (bjorn@helgaas.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |---

--- Comment #37 from Bjorn Helgaas (bjorn@helgaas.com) ---
Regarding the delay, i.e., this from Konrad's attachment at comment 27:

[    6.837625] DMAR: DRHD: handling fault status reg 2
[    6.837629] DMAR: [DMA Write NO_PASID] Request device [07:00.0] fault addr
0x69935000 [fault reason 0x05] PTE Write access is not set
[   26.937996] DMAR: DRHD: handling fault status reg 2
[   26.944592] DMAR: [DMA Write NO_PASID] Request device [07:00.0] fault addr
0x69935000 [fault reason 0x05] PTE Write access is not set
[   47.417982] DMAR: DRHD: handling fault status reg 2
[   47.424711] DMAR: [DMA Write NO_PASID] Request device [07:00.0] fault addr
0x69935000 [fault reason 0x05] PTE Write access is not set 
[   67.897999] DMAR: DRHD: handling fault status reg 2
[   67.904639] DMAR: [DMA Write NO_PASID] Request device [07:00.0] fault addr
0x69935000 [fault reason 0x05] PTE Write access is not set
[   88.372827] thunderbolt 0000:07:00.0: failed to send driver ready to ICM
[   88.380241] thunderbolt: probe of 0000:07:00.0 failed with error -110

This all involves the same device (07:00.0) and it's all likely related, so I
think we should reserve *this* bug report for this DMAR/timeout issue.

As far as I can tell, this is unrelated to bug 206459 and the E820 issues
addressed by Hans de Goede's patches, so I'm going to reopen this bug report.

If we're lucky, maybe the DMAR/timeout stuff has been fixed by something
between v5.15 and v6.0.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #38 from wse@tuxedocomputers.com ---
(In reply to Konrad J Hambrick from comment #36)
> Thanks for all the info wse@tuxedocomputers.com
> 
> The comments in Hans de Goede's three patches look familiar but I'll try all
> three patches against 5.15.y again.
> 
> Or should I be running a different Kernel Version ?
> 
> The Code referenced at elixir.bootlin.com is from Kernel Version 6.0.7 ...
> 
> I'll test next weekend when I've got time to build ; boot ; dmesg ; repeat 
> 
> Then I will open a new bug report.
> 
> Thank you and thank you and Tuxedo Computers for the tuxedo-keyboard-master
> and tuxedo-keyboard-ite kernel modules ( they work great for me ) !
> 
> -- kjh

the two lines are the same in 5.15.77

https://elixir.bootlin.com/linux/v5.15.77/source/drivers/thunderbolt/icm.c#L1024

https://elixir.bootlin.com/linux/v5.15.77/source/drivers/thunderbolt/icm.c#L1630

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #39 from Konrad J Hambrick (kjhambrick@gmail.com) ---
Created attachment 303142
  --> https://bugzilla.kernel.org/attachment.cgi?id=303142&action=edit
lspci -vvv for my Sager NP9672M / Clevo X170KM-G

Thanks Bjorn

Attached is lspci -vvv on the unpatched 5.15.77 Kernel if it helps.

It is large-ish but more may be better than less.

Should I try Linux 6.0.7 or maybe even 6.1.rc3 ?

-- kjh

# uname -a

Linux kjhlt7.kjh.home 5.15.77.kjh #1 SMP PREEMPT Thu Nov 3 10:27:53 CDT 2022
x86_64 11th Gen Intel(R) Core(TM) i9-11900K @ 3.50GHz GenuineIntel GNU/Linux

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #40 from Konrad J Hambrick (kjhambrick@gmail.com) ---
(In reply to wse from comment #38)
> (In reply to Konrad J Hambrick from comment #36)
> > Thanks for all the info wse@tuxedocomputers.com
> > 
> > The Code referenced at elixir.bootlin.com is from Kernel Version 6.0.7 ...
> > 
> 
> the two lines are the same in 5.15.77
> 
> https://elixir.bootlin.com/linux/v5.15.77/source/drivers/thunderbolt/icm.
> c#L1024
> 
> https://elixir.bootlin.com/linux/v5.15.77/source/drivers/thunderbolt/icm.
> c#L1630

Thanks wse@tuxedocomputers.com 

See Bjorn's post -- I'll wait and see what he finds.

-- kjh

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #41 from wse@tuxedocomputers.com ---
Just tested 6.1-rc4 (from ubuntu mainline ppa)

Still same behaviour: 4*20s delay during boot, but works just fine afterwards.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #42 from wse@tuxedocomputers.com ---
Created attachment 303144
  --> https://bugzilla.kernel.org/attachment.cgi?id=303144&action=edit
dmesg after boot (gui did not load but that seems an unrelated bug because rc)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

--- Comment #43 from wse@tuxedocomputers.com ---
Created attachment 303145
  --> https://bugzilla.kernel.org/attachment.cgi?id=303145&action=edit
connecting a dock after boot, worked just fine

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 214259] Discrete Thunderbold Controller 8086:1137 throws DMAR and XHCI errors and is only partially functional

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=214259

Bjorn Helgaas (bjorn@helgaas.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|USB                         |PCI
           Assignee|drivers_usb@kernel-bugs.ker |drivers_pci@kernel-bugs.osd
                   |nel.org                     |l.org

--- Comment #44 from Bjorn Helgaas (bjorn@helgaas.com) ---
Reassigning to PCI because I don't think this is a USB issue.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.