From: "André Draszik" <git@andred.net>
To: Peter Chen <peter.chen@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/3] usb: chipidea: imx: change hsic power regulator as optional
Date: Fri, 18 Oct 2019 16:13:30 +0100 [thread overview]
Message-ID: <c90a79b56ac3d13b79db4f4b3206be71232df147.camel@andred.net> (raw)
In-Reply-To: <20191011054129.20502-1-peter.chen@nxp.com>
Peter,
Thank you for this series, I was out so I will test it early next week
and report.
Cheers,
Andre'
On Fri, 2019-10-11 at 05:42 +0000, Peter Chen wrote:
> Not every platform needs this regulator.
>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 16700170bc34..25a38ed27aa8 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -359,7 +359,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> return PTR_ERR(data->pinctrl_hsic_active);
> }
>
> - data->hsic_pad_regulator = devm_regulator_get(dev, "hsic");
> + data->hsic_pad_regulator =
> + devm_regulator_get_optional(dev, "hsic");
> if (PTR_ERR(data->hsic_pad_regulator) == -EPROBE_DEFER) {
> return -EPROBE_DEFER;
> } else if (PTR_ERR(data->hsic_pad_regulator) == -ENODEV) {
prev parent reply other threads:[~2019-10-18 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 5:42 [PATCH 1/3] usb: chipidea: imx: change hsic power regulator as optional Peter Chen
2019-10-11 5:42 ` [PATCH 2/3] usb: chipidea: imx: refine the error handling for hsic Peter Chen
2019-10-11 5:42 ` [PATCH 3/3] usb: chipidea: imx: pinctrl for HSIC is optional Peter Chen
2019-10-18 15:13 ` André Draszik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c90a79b56ac3d13b79db4f4b3206be71232df147.camel@andred.net \
--to=git@andred.net \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).