From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: John Keeping <john@metanate.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc2: gadget: use existing helper
Date: Tue, 23 Nov 2021 05:17:15 +0000 [thread overview]
Message-ID: <d18a3b7c-c6ec-5967-d0d3-8fdbb0716cd5@synopsys.com> (raw)
In-Reply-To: <20211122123107.3147353-1-john@metanate.com>
On 11/22/2021 4:31 PM, John Keeping wrote:
> All other checks of params.g_dma_desc in this file use the
> using_desc_dma() helper function. Use that helper in two more places
> for consistency throughout the file.
>
> Signed-off-by: John Keeping <john@metanate.com>
Acked-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
> ---
> drivers/usb/dwc2/gadget.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index ab8d7dad9f567..b884a83b26a6e 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -5217,7 +5217,7 @@ int dwc2_restore_device_registers(struct dwc2_hsotg *hsotg, int remote_wakeup)
> * as result BNA interrupt asserted on hibernation exit
> * by restoring from saved area.
> */
> - if (hsotg->params.g_dma_desc &&
> + if (using_desc_dma(hsotg) &&
> (dr->diepctl[i] & DXEPCTL_EPENA))
> dr->diepdma[i] = hsotg->eps_in[i]->desc_list_dma;
> dwc2_writel(hsotg, dr->dtxfsiz[i], DPTXFSIZN(i));
> @@ -5229,7 +5229,7 @@ int dwc2_restore_device_registers(struct dwc2_hsotg *hsotg, int remote_wakeup)
> * as result BNA interrupt asserted on hibernation exit
> * by restoring from saved area.
> */
> - if (hsotg->params.g_dma_desc &&
> + if (using_desc_dma(hsotg) &&
> (dr->doepctl[i] & DXEPCTL_EPENA))
> dr->doepdma[i] = hsotg->eps_out[i]->desc_list_dma;
> dwc2_writel(hsotg, dr->doepdma[i], DOEPDMA(i));
>
prev parent reply other threads:[~2021-11-23 5:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 12:31 [PATCH] usb: dwc2: gadget: use existing helper John Keeping
2021-11-23 5:17 ` Minas Harutyunyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d18a3b7c-c6ec-5967-d0d3-8fdbb0716cd5@synopsys.com \
--to=minas.harutyunyan@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=john@metanate.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).