Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* [RESENDING RFC PATCH 0/4] Add logic to consolidate TRBs for Synopsys xHC
@ 2020-03-27  8:52 Tejas Joglekar
  2020-03-27  8:34 ` [RFC PATCH 1/4] dt-bindings: usb: Add snps,consolidate-sgl & consolidate-sgl Tejas Joglekar
                   ` (4 more replies)
  0 siblings, 5 replies; 24+ messages in thread
From: Tejas Joglekar @ 2020-03-27  8:52 UTC (permalink / raw)
  To: Felipe Balbi, Tejas Joglekar, linux-usb, devicetree, Rob Herring,
	Chunfeng Yun, Fredrik Noring, Mathias Nyman, Mark Rutland,
	Sebastian Andrzej Siewior, Raul E Rangel, Laurentiu Tudor,
	Marek Szyprowski
  Cc: John Youn

The Synopsys xHC has an internal TRB cache of size TRB_CACHE_SIZE for
each endpoint. The default value for TRB_CACHE_SIZE is 16 for SS and 8
for HS. The controller loads and updates the TRB cache from the
transfer ring in system memory whenever the driver issues a start
transfer or update transfer command.

For chained TRBs, the Synopsys xHC requires that the total amount of
bytes for all TRBs loaded in the TRB cache be greater than or equal to
1 MPS. Or the chain ends within the TRB cache (with a last TRB).

If this requirement is not met, the controller will not be able to
send or receive a packet and it will hang causing a driver timeout and
error.

This patch set adds logic to the XHCI driver to detect and prevent this
from happening along with the quirk to enable this logic for Synopsys
HAPS platform.

Based on Mathias's feedback on previous implementation where consolidation
was done in TRB cache, with this patch series the implementation is done
during mapping of the URB by consolidating the SG list into a temporary
buffer if the SG list buffer sizes within TRB_CACHE_SIZE is less than MPS.


Tejas Joglekar (4):
  dt-bindings: usb: Add snps,consolidate-sgl & consolidate-sgl
  usb: xhci: Set quirk for XHCI_CONSOLIDATE_SG_LIST
  usb: dwc3: Add device property consolidate-sgl
  usb: xhci: Use temporary buffer to consolidate SG

Resending as 'umlaut' is not accepted by some servers in email.

 Documentation/devicetree/bindings/usb/dwc3.txt     |   3 +
 Documentation/devicetree/bindings/usb/usb-xhci.txt |   3 +
 drivers/usb/core/hcd.c                             |   8 ++
 drivers/usb/dwc3/core.c                            |   2 +
 drivers/usb/dwc3/core.h                            |   2 +
 drivers/usb/dwc3/dwc3-haps.c                       |   1 +
 drivers/usb/dwc3/host.c                            |   5 +-
 drivers/usb/host/xhci-pci.c                        |   3 +
 drivers/usb/host/xhci-plat.c                       |   3 +
 drivers/usb/host/xhci-ring.c                       |   2 +-
 drivers/usb/host/xhci.c                            | 128 +++++++++++++++++++++
 drivers/usb/host/xhci.h                            |   5 +
 12 files changed, 163 insertions(+), 2 deletions(-)

-- 
2.11.0


^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, back to index

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-27  8:52 [RESENDING RFC PATCH 0/4] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
2020-03-27  8:34 ` [RFC PATCH 1/4] dt-bindings: usb: Add snps,consolidate-sgl & consolidate-sgl Tejas Joglekar
2020-03-27  9:41   ` [RESENDING RFC " Tejas Joglekar
2020-03-27  9:54   ` Greg KH
2020-03-27 10:11     ` Tejas Joglekar
2020-03-27 10:24       ` Greg KH
2020-03-27 10:28         ` Tejas Joglekar
2020-04-05  1:45   ` Rob Herring
2020-04-14 10:09     ` Tejas Joglekar
2020-04-16  8:22       ` Felipe Balbi
2020-04-16 16:37         ` Tejas Joglekar
2020-04-17 11:44           ` Mathias Nyman
2020-03-27  8:35 ` [RFC PATCH 2/4] usb: xhci: Set quirk for XHCI_CONSOLIDATE_SG_LIST Tejas Joglekar
2020-03-27  9:42   ` [RESENDING RFC " Tejas Joglekar
2020-03-27  8:35 ` [RFC PATCH 3/4] usb: dwc3: Add device property consolidate-sgl Tejas Joglekar
2020-03-27  9:42   ` [RESENDING RFC " Tejas Joglekar
2020-03-27  8:53 ` [RESENDING RFC PATCH 4/4] usb: xhci: Use temporary buffer to consolidate SG Tejas Joglekar
2020-03-27  9:27   ` Greg KH
2020-03-27 10:05     ` Tejas Joglekar
2020-03-27 10:22       ` Greg KH
2020-03-27 11:25         ` Mathias Nyman
2020-03-27 15:38           ` Raul Rangel
2020-03-27  9:28 ` [RESENDING RFC PATCH 0/4] Add logic to consolidate TRBs for Synopsys xHC Greg KH
2020-03-27  9:43   ` Tejas Joglekar

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git