linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lubomir Rintel <lkundrak@v3.sk>
To: Johan Hovold <johan@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] media: usbtv: fix control-message timeouts
Date: Mon, 13 Jan 2020 19:15:56 +0100	[thread overview]
Message-ID: <d292dfbb9b10129c76f7a282c5a1015b04b775dd.camel@v3.sk> (raw)
In-Reply-To: <20200113171818.30715-1-johan@kernel.org>

On Mon, 2020-01-13 at 18:18 +0100, Johan Hovold wrote:
> The driver was issuing synchronous uninterruptible control requests
> without using a timeout. This could lead to the driver hanging on
> various user requests due to a malfunctioning (or malicious) device
> until the device is physically disconnected.
> 
> The USB upper limit of five seconds per request should be more than
> enough.
> 
> Fixes: f3d27f34fdd7 ("[media] usbtv: Add driver for Fushicai USBTV007 video frame grabber")
> Fixes: c53a846c48f2 ("[media] usbtv: add video controls")
> Cc: stable <stable@vger.kernel.org>     # 3.11
> Cc: Lubomir Rintel <lkundrak@v3.sk>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Acked-by: Lubomir Rintel <lkundrak@v3.sk>

Thank you,
Lubo

> ---
>  drivers/media/usb/usbtv/usbtv-core.c  | 2 +-
>  drivers/media/usb/usbtv/usbtv-video.c | 5 +++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/usb/usbtv/usbtv-core.c b/drivers/media/usb/usbtv/usbtv-core.c
> index 5095c380b2c1..ee9c656d121f 100644
> --- a/drivers/media/usb/usbtv/usbtv-core.c
> +++ b/drivers/media/usb/usbtv/usbtv-core.c
> @@ -56,7 +56,7 @@ int usbtv_set_regs(struct usbtv *usbtv, const u16 regs[][2], int size)
>  
>  		ret = usb_control_msg(usbtv->udev, pipe, USBTV_REQUEST_REG,
>  			USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> -			value, index, NULL, 0, 0);
> +			value, index, NULL, 0, USB_CTRL_GET_TIMEOUT);
>  		if (ret < 0)
>  			return ret;
>  	}
> diff --git a/drivers/media/usb/usbtv/usbtv-video.c b/drivers/media/usb/usbtv/usbtv-video.c
> index 3d9284a09ee5..b249f037900c 100644
> --- a/drivers/media/usb/usbtv/usbtv-video.c
> +++ b/drivers/media/usb/usbtv/usbtv-video.c
> @@ -800,7 +800,8 @@ static int usbtv_s_ctrl(struct v4l2_ctrl *ctrl)
>  		ret = usb_control_msg(usbtv->udev,
>  			usb_rcvctrlpipe(usbtv->udev, 0), USBTV_CONTROL_REG,
>  			USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> -			0, USBTV_BASE + 0x0244, (void *)data, 3, 0);
> +			0, USBTV_BASE + 0x0244, (void *)data, 3,
> +			USB_CTRL_GET_TIMEOUT);
>  		if (ret < 0)
>  			goto error;
>  	}
> @@ -851,7 +852,7 @@ static int usbtv_s_ctrl(struct v4l2_ctrl *ctrl)
>  	ret = usb_control_msg(usbtv->udev, usb_sndctrlpipe(usbtv->udev, 0),
>  			USBTV_CONTROL_REG,
>  			USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> -			0, index, (void *)data, size, 0);
> +			0, index, (void *)data, size, USB_CTRL_SET_TIMEOUT);
>  
>  error:
>  	if (ret < 0)


  reply	other threads:[~2020-01-13 18:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 17:18 [PATCH] media: usbtv: fix control-message timeouts Johan Hovold
2020-01-13 18:15 ` Lubomir Rintel [this message]
2020-01-13 18:26 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d292dfbb9b10129c76f7a282c5a1015b04b775dd.camel@v3.sk \
    --to=lkundrak@v3.sk \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).