From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63361C433E4 for ; Thu, 13 Aug 2020 10:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48B7B206A4 for ; Thu, 13 Aug 2020 10:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726593AbgHMKbh convert rfc822-to-8bit (ORCPT ); Thu, 13 Aug 2020 06:31:37 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:35289 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726048AbgHMKbf (ORCPT ); Thu, 13 Aug 2020 06:31:35 -0400 Received: from [37.161.87.136] (port=46755 helo=[192.168.42.162]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1k6AW9-000FlW-5k; Thu, 13 Aug 2020 12:31:29 +0200 Subject: Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files To: Rob Herring , devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, alsa-devel@alsa-project.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org References: <20200812203618.2656699-1-robh@kernel.org> From: Luca Ceresoli Message-ID: Date: Thu, 13 Aug 2020 12:31:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200812203618.2656699-1-robh@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8BIT X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Rob, On 12/08/20 22:36, Rob Herring wrote: > Clean-up incorrect indentation, extra spaces, long lines, and missing > EOF newline in schema files. Most of the clean-ups are for list > indentation which should always be 2 spaces more than the preceding > keyword. > > Found with yamllint (which I plan to integrate into the checks). [...] > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > index 3d4e1685cc55..28c6461b9a9a 100644 > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > @@ -95,10 +95,10 @@ allOf: > # Devices without builtin crystal > properties: > clock-names: > - minItems: 1 > - maxItems: 2 > - items: > - enum: [ xin, clkin ] > + minItems: 1 > + maxItems: 2 > + items: > + enum: [ xin, clkin ] > clocks: > minItems: 1 > maxItems: 2 Thanks for noticing, LGTM. [...] > diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > index d7dac16a3960..36dc7b56a453 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > @@ -33,8 +33,8 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > > touchscreen-min-pressure: > - description: minimum pressure on the touchscreen to be achieved in order for the > - touchscreen driver to report a touch event. > + description: minimum pressure on the touchscreen to be achieved in order > + for the touchscreen driver to report a touch event. Out of personal taste, I find the original layout more pleasant and readable. This third option is also good, especially for long descriptions: description: minimum pressure on the touchscreen to be achieved in order for the touchscreen driver to report a touch event. At first glance yamllint seems to support exactly these two by default: > With indentation: {spaces: 4, check-multi-line-strings: true} > > the following code snippet would PASS: > > Blaise Pascal: > Je vous écris une longue lettre parce que > je n'ai pas le temps d'en écrire une courte. > > the following code snippet would PASS: > > Blaise Pascal: Je vous écris une longue lettre parce que > je n'ai pas le temps d'en écrire une courte. > > the following code snippet would FAIL: > > Blaise Pascal: Je vous écris une longue lettre parce que > je n'ai pas le temps d'en écrire une courte. > (https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.indentation) -- Luca