From: <Cristian.Birsan@microchip.com>
To: <Julia.Lawall@inria.fr>
Cc: <kernel-janitors@vger.kernel.org>, <balbi@kernel.org>,
<gregkh@linuxfoundation.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/16] usb: gadget: udc: atmel: constify copied structure
Date: Mon, 6 Jan 2020 11:16:05 +0000 [thread overview]
Message-ID: <d81c389b-f377-8ff0-7206-70c9b9a01f4a@microchip.com> (raw)
In-Reply-To: <1577864614-5543-5-git-send-email-Julia.Lawall@inria.fr>
On 1/1/20 9:43 AM, Julia Lawall wrote:
> The usba_gadget_template structure is only copied into another
> structure, so make it const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Acked-by: Cristian Birsan <cristian.birsan@microchip.com>
>
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 8a42768e3213..6e0432141c40 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1122,7 +1122,7 @@ static struct usb_endpoint_descriptor usba_ep0_desc = {
> .bInterval = 1,
> };
>
> -static struct usb_gadget usba_gadget_template = {
> +static const struct usb_gadget usba_gadget_template = {
> .ops = &usba_udc_ops,
> .max_speed = USB_SPEED_HIGH,
> .name = "atmel_usba_udc",
>
prev parent reply other threads:[~2020-01-06 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 7:43 [PATCH 00/16] constify copied structure Julia Lawall
2020-01-01 7:43 ` [PATCH 04/16] usb: gadget: udc: atmel: " Julia Lawall
2020-01-06 11:16 ` Cristian.Birsan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d81c389b-f377-8ff0-7206-70c9b9a01f4a@microchip.com \
--to=cristian.birsan@microchip.com \
--cc=Julia.Lawall@inria.fr \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).