Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
	Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>,
	Mathias Nyman <mathias.nyman@intel.com>
Cc: John Youn <John.Youn@synopsys.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v5 0/3] Add logic to consolidate TRBs for Synopsys xHC
Date: Wed, 28 Oct 2020 15:20:27 +0000
Message-ID: <d84e4b5c-0d7a-50e2-25a1-5be1da9ca72a@synopsys.com> (raw)
In-Reply-To: <09737ac8-66a0-564c-2f1c-60a92ec716b5@linux.intel.com>

Hi,
On 10/28/2020 8:12 PM, Mathias Nyman wrote:
> On 27.10.2020 20.28, Tejas Joglekar wrote:
>> Hi Mathias,
>> On 10/16/2020 6:34 PM, Tejas Joglekar wrote:
>>> The Synopsys xHC has an internal TRB cache of size TRB_CACHE_SIZE for
>>> each endpoint. The default value for TRB_CACHE_SIZE is 16 for SS and 8
>>> for HS. The controller loads and updates the TRB cache from the
>>> transfer ring in system memory whenever the driver issues a start
>>> transfer or update transfer command.
>>>
>>> For chained TRBs, the Synopsys xHC requires that the total amount of
>>> bytes for all TRBs loaded in the TRB cache be greater than or equal to
>>> 1 MPS. Or the chain ends within the TRB cache (with a last TRB).
>>>
>>> If this requirement is not met, the controller will not be able to
>>> send or receive a packet and it will hang causing a driver timeout and
>>> error.
>>>
>>> This patch set adds logic to the XHCI driver to detect and prevent this
>>> from happening along with the quirk to enable this logic for Synopsys
>>> HAPS platform.
>>>
>>> Based on Mathias's feedback on previous implementation where consolidation
>>> was done in TRB cache, with this patch series the implementation is done
>>> during mapping of the URB by consolidating the SG list into a temporary
>>> buffer if the SG list buffer sizes within TRB_CACHE_SIZE is less than MPS.
>>>
>>> Changes since v4:
>>>  - Updated [Patch 3/3] platform data structure initialization
>>>  - Trivial changes in commit wordings
>>>
>>> Changes since v3:
>>>  - Removed the dt-binding patch
>>>  - Added new patch to pass the quirk as platform data
>>>  - Modified the patch to set the quirk
>>>
>>> Changes since v2:
>>>  - Modified the xhci_unmap_temp_buffer function to unmap dma and c
>>>    the dma flag
>>>  - Removed RFC tag
>>>
>>> Changes since v1:
>>>  - Comments from Greg are addressed on [PATCH 4/4] and [PATCH 1/4]
>>>  - Renamed the property and quirk as in other patches based on [PATCH 1/4]
>>>
>>>
>>>
>>> Tejas Joglekar (3):
>>>   usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK
>>>   usb: xhci: Use temporary buffer to consolidate SG
>>>   usb: dwc3: Pass quirk as platform data
>>>
>>>  drivers/usb/dwc3/host.c      |  10 +++
>>>  drivers/usb/host/xhci-plat.c |   3 +
>>>  drivers/usb/host/xhci-ring.c |   2 +-
>>>  drivers/usb/host/xhci.c      | 137 ++++++++++++++++++++++++++++++++++-
>>>  drivers/usb/host/xhci.h      |   5 ++
>>>  5 files changed, 155 insertions(+), 2 deletions(-)
>>>
>>
>> I have removed the dependency on setting quirk through device tree binding
>> and added the quirk using platform data. Can you please review and if 
>> everything looks OK, can you please add this patch series to your tree?
> 
> Sure, there aren't any functional changes to xhci since v3 of this series right?
> And if I remember correctly Felipe didn't have any objections to the dwc3 part either.
> 
You are right, there are no functional changes to xhci since v3.

> Felipe, do you want to take the 3/3 dwc3 patch separately after 1/3 and 2/3 are in, or should
> I take them all, or ask if Greg would like to pick up this series?
> 
> -Mathias 
> 

Regards,
Tejas Joglekar

  parent reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 13:04 Tejas Joglekar
2020-10-16 13:04 ` [PATCH v5 1/3] usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK Tejas Joglekar
2020-10-16 13:05 ` [PATCH v5 2/3] usb: xhci: Use temporary buffer to consolidate SG Tejas Joglekar
2020-10-16 13:05 ` [PATCH v5 3/3] usb: dwc3: Pass quirk as platform data Tejas Joglekar
2020-10-27 18:28 ` [PATCH v5 0/3] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
     [not found]   ` <09737ac8-66a0-564c-2f1c-60a92ec716b5@linux.intel.com>
2020-10-28 15:20     ` Tejas Joglekar [this message]
2020-11-06 16:06       ` Tejas Joglekar
2020-11-12  2:31         ` Tejas Joglekar
2020-11-17 17:16           ` Tejas Joglekar
2020-11-18 14:09             ` Mathias Nyman
2020-11-19  1:19               ` Tejas Joglekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d84e4b5c-0d7a-50e2-25a1-5be1da9ca72a@synopsys.com \
    --to=tejas.joglekar@synopsys.com \
    --cc=John.Youn@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mathias.nyman@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git