From: <Charles.Hyde@dellteam.com>
To: <bjorn@mork.no>
Cc: <stern@rowland.harvard.edu>, <oliver@neukum.org>,
<rjw@rjwysocki.net>, <lenb@kernel.org>,
<Mario.Limonciello@dell.com>, <chip.programmer@gmail.com>,
<nic_swsd@realtek.com>, <linux-usb@vger.kernel.org>,
<linux-acpi@vger.kernel.org>
Subject: RE: [PATCH 1/3] net: cdc_ncm: add get/set ethernet address functions
Date: Fri, 6 Sep 2019 20:20:13 +0000 [thread overview]
Message-ID: <d8cdacc63ddd4da4a88d3712b2b53d32@AUSX13MPS307.AMER.DELL.COM> (raw)
In-Reply-To: <87mufhqjdb.fsf@miraculix.mork.no>
> > What better suggestion do folks have, instead of using
> USB_REQ_SET_ADDRESS?
>
> The spec is clear: wIndex is supposed to be 'NCM Communications Interface'.
> That's how you address a specific NCM function (a USB device can have more
> than one...), and that's what you'll see in all the other interface specific class
> requests in this driver. You don't have to look hard to find examples.
>
>
> Bjørn
I have presented what works, with the v3 patch series. Since you obviously do not like what does work, I will ask you to provide clear and concise code for what you believe ought to work. Mind you, the code I have provided sends the exact same USB message as I traced with Wireshark on my Windows system. If you can provide good working code that replicates what I have provided, I would be thrilled.
Thank you,
Charles
next prev parent reply other threads:[~2019-09-06 20:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 21:01 [PATCH 1/3] net: cdc_ncm: add get/set ethernet address functions Charles.Hyde
2019-09-06 9:02 ` Bjørn Mork
2019-09-06 18:00 ` Charles.Hyde
2019-09-06 18:15 ` Alan Stern
2019-09-06 18:19 ` Charles.Hyde
2019-09-06 20:07 ` Bjørn Mork
2019-09-06 20:20 ` Charles.Hyde [this message]
2019-09-06 20:39 ` Bjørn Mork
2019-09-06 21:00 ` Charles.Hyde
-- strict thread matches above, loose matches on Subject: below --
2019-08-30 19:37 Charles.Hyde
2019-09-02 9:43 ` Oliver Neukum
2019-09-03 16:45 ` Charles.Hyde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8cdacc63ddd4da4a88d3712b2b53d32@AUSX13MPS307.AMER.DELL.COM \
--to=charles.hyde@dellteam.com \
--cc=Mario.Limonciello@dell.com \
--cc=bjorn@mork.no \
--cc=chip.programmer@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oliver@neukum.org \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).