From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: jiahao <jiahao243@gmail.com>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org,
jiahao@xiaomi.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xhci: Fix log mistake of xhci_start
Date: Fri, 15 May 2020 09:53:22 +0300 [thread overview]
Message-ID: <dd0ff565-2222-8bf0-c379-5e5d97975e98@linux.intel.com> (raw)
In-Reply-To: <1589521506-19492-1-git-send-email-jiahao@xiaomi.com>
On 15.5.2020 8.45, jiahao wrote:
> It is obvious that XCHI_MAX_HALT_USEC is usec,
> not milliseconds; Replace 'milliseconds' with
> 'usec' of the debug message.
>
> Signed-off-by: jiahao <jiahao@xiaomi.com>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index bee5dec..d011472 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -147,7 +147,7 @@ int xhci_start(struct xhci_hcd *xhci)
> STS_HALT, 0, XHCI_MAX_HALT_USEC);
> if (ret == -ETIMEDOUT)
> xhci_err(xhci, "Host took too long to start, "
> - "waited %u microseconds.\n",
> + "waited %u usec.\n",
It already says "microseconds", no need to change it
-Mathias
next prev parent reply other threads:[~2020-05-15 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 5:45 [PATCH] xhci: Fix log mistake of xhci_start jiahao
2020-05-15 6:53 ` Mathias Nyman [this message]
2020-05-15 9:21 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd0ff565-2222-8bf0-c379-5e5d97975e98@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiahao243@gmail.com \
--cc=jiahao@xiaomi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).