From: Kishon Vijay Abraham I <kishon@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Alan Stern <stern@rowland.harvard.edu>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<chris.chiu@canonical.com>, <lokeshvutla@ti.com>
Subject: Re: [PATCH 3/3] xhci: Set HCD flag to defer primary roothub registration
Date: Wed, 25 Aug 2021 20:16:53 +0530 [thread overview]
Message-ID: <e16a6657-5fa3-52cb-e5ea-710c77e457d8@ti.com> (raw)
In-Reply-To: <20210825105132.10420-4-kishon@ti.com>
Hi,
On 25/08/21 4:21 pm, Kishon Vijay Abraham I wrote:
> Set "HCD_FLAG_DEFER_PRI_RH_REGISTER" to hcd->flags in xhci_run() to defer
> registering primary roothub in usb_add_hcd(). This will make sure both
> primary roothub and secondary roothub will be registered along with the
> second HCD. This is required for cold plugged USB devices to be detected
> in certain PCIe USB cards (like Inateck USB card connected to AM64 EVM
> or J7200 EVM).
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Suggested-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 3618070eba78..9b7d968022c8 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -644,7 +644,6 @@ int xhci_run(struct usb_hcd *hcd)
> /* Start the xHCI host controller running only after the USB 2.0 roothub
> * is setup.
> */
> -
I just realized I've left a spurious space here. While fixing Alan's
comment, I'll fix this one.
Regards,
Kishon
> hcd->uses_new_polling = 1;
> if (!usb_hcd_is_primary_hcd(hcd))
> return xhci_run_finished(xhci);
> @@ -692,6 +691,7 @@ int xhci_run(struct usb_hcd *hcd)
> if (ret)
> xhci_free_command(xhci, command);
> }
> + set_bit(HCD_FLAG_DEFER_PRI_RH_REGISTER, &hcd->flags);
> xhci_dbg_trace(xhci, trace_xhci_dbg_init,
> "Finished xhci_run for USB2 roothub");
>
>
prev parent reply other threads:[~2021-08-25 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 10:51 [PATCH 0/3] Fix cold plugged USB device on certain PCIe USB cards Kishon Vijay Abraham I
2021-08-25 10:51 ` [PATCH 1/3] usb: core: hcd: Modularize HCD stop configuration in usb_stop_hcd() Kishon Vijay Abraham I
2021-08-25 14:45 ` Alan Stern
2021-08-25 10:51 ` [PATCH 2/3] usb: core: hcd: Add support for deferring roothub registration Kishon Vijay Abraham I
2021-08-25 14:52 ` Alan Stern
2021-08-25 10:51 ` [PATCH 3/3] xhci: Set HCD flag to defer primary " Kishon Vijay Abraham I
2021-08-25 14:46 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e16a6657-5fa3-52cb-e5ea-710c77e457d8@ti.com \
--to=kishon@ti.com \
--cc=chris.chiu@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).