Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 7/7] usb: typec: Remove the callback members from struct typec_capability
Date: Sat, 5 Oct 2019 10:37:51 -0700
Message-ID: <e6ff8434-5f09-5e86-a32b-eea2834dbd28@roeck-us.net> (raw)
In-Reply-To: <20191004150817.45413-8-heikki.krogerus@linux.intel.com>

On 10/4/19 8:08 AM, Heikki Krogerus wrote:
> There are no more users for them.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>   drivers/usb/typec/class.c | 38 ++++++++++----------------------------
>   include/linux/usb/typec.h | 17 -----------------
>   2 files changed, 10 insertions(+), 45 deletions(-)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index f4972b7ee022..e7b92f650ba0 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -52,7 +52,6 @@ struct typec_port {
>   	struct typec_switch		*sw;
>   	struct typec_mux		*mux;
>   
> -	const struct typec_capability	*orig_cap; /* to be removed */
>   	const struct typec_capability	*cap;
>   	const struct typec_operations   *ops;
>   };
> @@ -957,7 +956,7 @@ preferred_role_store(struct device *dev, struct device_attribute *attr,
>   		return -EOPNOTSUPP;
>   	}
>   
> -	if (!port->cap->try_role || (!port->ops && !port->ops->try_role)) {
> +	if (!port->ops && !port->ops->try_role) {

I think this should be
	if (!port->ops || !port->ops->try_role) {
or the code would crash if port->ops is NULL. Same everywhere else below.

Guenter

      reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04 15:08 [PATCH v2 0/7] usb: typec: Small API improvement Heikki Krogerus
2019-10-04 15:08 ` [PATCH v2 1/7] usb: typec: Copy everything from struct typec_capability during registration Heikki Krogerus
2019-10-04 15:08 ` [PATCH v2 2/7] usb: typec: Introduce typec_get_drvdata() Heikki Krogerus
2019-10-04 15:08 ` [PATCH v2 3/7] usb: typec: Separate the operations vector Heikki Krogerus
2019-10-04 15:17   ` Heikki Krogerus
2019-10-05 17:36   ` Guenter Roeck
2019-10-07  8:44     ` Heikki Krogerus
2019-10-04 15:08 ` [PATCH v2 4/7] usb: typec: tcpm: Start using struct typec_operations Heikki Krogerus
2019-10-05 17:39   ` Guenter Roeck
2019-10-04 15:08 ` [PATCH v2 5/7] usb: typec: tps6598x: " Heikki Krogerus
2019-10-04 15:08 ` [PATCH v2 6/7] usb: typec: ucsi: " Heikki Krogerus
2019-10-04 15:08 ` [PATCH v2 7/7] usb: typec: Remove the callback members from struct typec_capability Heikki Krogerus
2019-10-05 17:37   ` Guenter Roeck [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6ff8434-5f09-5e86-a32b-eea2834dbd28@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git