From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-usb-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB68C7618B
	for <linux-usb@archiver.kernel.org>; Sat, 18 Mar 2023 15:25:14 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229813AbjCRPZL (ORCPT <rfc822;linux-usb@archiver.kernel.org>);
        Sat, 18 Mar 2023 11:25:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43780 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229651AbjCRPZK (ORCPT
        <rfc822;linux-usb@vger.kernel.org>); Sat, 18 Mar 2023 11:25:10 -0400
X-Greylist: delayed 554 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 18 Mar 2023 08:25:07 PDT
Received: from out-54.mta1.migadu.com (out-54.mta1.migadu.com [IPv6:2001:41d0:203:375::36])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C0CA18AA5
        for <linux-usb@vger.kernel.org>; Sat, 18 Mar 2023 08:25:06 -0700 (PDT)
Message-ID: <e872037e88af46ee4a329a2bee39806533365018.camel@linux.dev>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
        t=1679152549;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=vR0CuRyOezUnFd4VADqINnV0NjCLi52z5JOf95rttMc=;
        b=nkBTJv/plWRp2yCy0P23isJwXeNfkbNbENfU8+lTZkCIW+dwnF7+QREz9rFYCuCEkV+JJo
        czxTLKhE4R3uCvLVTZGgfDgp3g/JwpnLAemWp1UH4Wb6osoXt1SxWQSZEy9EwdtXa6Yd9K
        XXuW91zDtpaqstTSIH2YGt4dF4xdHoc=
Subject: Re: [RFC PATCH v1] usb/phy add sprd ums512 usbphy
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From:   Cixi Geng <cixi.geng@linux.dev>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     orsonzhai@gmail.com, baolin.wang@linux.alibaba.com,
        zhang.lyra@gmail.com, arnd@arndb.de, tony@atomide.com,
        felipe.balbi@linux.intel.com, paul@crapouillou.net,
        linus.walleij@linaro.org, cixi.geng1@unisoc.com,
        gengcixi@gmail.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Date:   Sat, 18 Mar 2023 23:15:33 +0800
In-Reply-To: <ZA7DUH+qJyMmWBq5@kroah.com>
References: <20230312171438.177952-1-cixi.geng@linux.dev>
         <ZA7DUH+qJyMmWBq5@kroah.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Migadu-Flow: FLOW_OUT
Precedence: bulk
List-ID: <linux-usb.vger.kernel.org>
X-Mailing-List: linux-usb@vger.kernel.org

On Mon, 2023-03-13 at 07:31 +0100, Greg KH wrote:
> On Mon, Mar 13, 2023 at 01:14:38AM +0800, Cixi Geng wrote:
> > From: Cixi Geng <cixi.geng1@unisoc.com>
> >=20
> > This driver is support USB2 phy for Spreadtrum UMS512 SOC's,
> >=20
> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
>=20
> Why is this "RFC"?=C2=A0 What is left to do on it to be accepted?
this is just the driver code, lack of dt-bindings=20
>=20
> > ---
> > =C2=A0drivers/usb/phy/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 |=C2=A0 10 +
> > =C2=A0drivers/usb/phy/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 +
> > =C2=A0drivers/usb/phy/phy-sprd-ums512.c | 511
> > ++++++++++++++++++++++++++++++
> > =C2=A0drivers/usb/phy/phy-sprd-ums512.h |=C2=A0 39 +++
>=20
> Why do you need a .h file for a single .c file?=C2=A0 Please just put the=
m
> all together into one file.
>=20
> thanks,
>=20
> greg k-h