From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06651C43334 for ; Thu, 9 Jun 2022 06:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239222AbiFIGni (ORCPT ); Thu, 9 Jun 2022 02:43:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239170AbiFIGnh (ORCPT ); Thu, 9 Jun 2022 02:43:37 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AFAF36B54 for ; Wed, 8 Jun 2022 23:43:35 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id s12so38311641ejx.3 for ; Wed, 08 Jun 2022 23:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8QxMUDgvSlc7MUaIxRAHcd04jAxG/DT7Rwu9fAfBQ2c=; b=tlcMlE51v4xXs8km5CottKT0fJVznE2H+iY/m3DayYlsjEHHaGKQ6cjhtRtjkfGSQA 8DMG9b+iBnoChMP8N9+sK86V/N9e0gwqUcY6gVZCJoYhV+98tdqkhkkqwK4jBrZG8kF9 vXKweiVw3OReAfnWV7rEsbaUarzibEW20U6HX1CnDofiHwb1HrFH4duFmqCrIhwYOABK KKGGUuvo8D3bGXnBp5h/Pox0ZYWcTyGtEU2boRpiNlRJ+6XNdxE7vu4RbCecrm+qXGsJ rt5fj+LZ1ruM54v1bNLRTod7yi2KFO1u/m5oHkPOJHzmRlbxJNQift5D5c3rDYckKmpT zq2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8QxMUDgvSlc7MUaIxRAHcd04jAxG/DT7Rwu9fAfBQ2c=; b=jJWbI2as8vagDnsyyd6wfED+O3Q4O3wNwmQTbYPiffHBwpMb+om81wS08nS88tzmBu 2uBeDALeamZmqQHrm9ApCVMpE5I7CVKhpiDCTaLlFJpivs+YIzFeKudYQY7uADRtCvkQ dNqHbmq4OCZ2PrzOS/YvXMmaza5Jc7/YHIebOMqccnb2Djs6MdDRLnUIe7p3P2HQWwWD rA87KgMfnSdRw66m9wBNwyT2qVaq2QwPZvA15sS49IhnxGsrwqCG2RbKbAUlDh8qwkGE UWIfllkjbm/CV2EnSzh57mgMBpCVgM4dyDglZIj1M4yhDETx36kI2n1cb+mT3w3FNIO2 vzWw== X-Gm-Message-State: AOAM53363eovE/B3ADUaF6ulGlDa0+sfrRZjM9tr/SY+KRBDntE6NGQd hqOelm6/kxyAhwe2vL4btjEIFw== X-Google-Smtp-Source: ABdhPJyJWDZbpai3zzWk6O960xQFGdojO/DcT8ZiVIX77Fy5DCaULLfavPwnpkEVE+ZJXaVfJLwdog== X-Received: by 2002:a17:906:7944:b0:6da:b834:2f3e with SMTP id l4-20020a170906794400b006dab8342f3emr35639464ejo.353.1654757013799; Wed, 08 Jun 2022 23:43:33 -0700 (PDT) Received: from [192.168.0.194] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id a23-20020aa7cf17000000b0042dc882c823sm13752112edy.70.2022.06.08.23.43.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 23:43:32 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 08:43:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 3/7] dt-bindings: usb: Add Type-C switch binding Content-Language: en-US To: Prashant Malani Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, bleung@chromium.org, swboyd@chromium.org, heikki.krogerus@linux.intel.com, Andrzej Hajda , AngeloGioacchino Del Regno , Daniel Vetter , David Airlie , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:DRM DRIVERS" , Greg Kroah-Hartman , Hsin-Yi Wang , Jernej Skrabec , Jonas Karlman , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Krzysztof Kozlowski , Laurent Pinchart , Maxime Ripard , Neil Armstrong , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Pin-Yen Lin , Robert Foss , Rob Herring , Sam Ravnborg , Thomas Zimmermann , Tzung-Bi Shih , Xin Ji References: <20220607190131.1647511-1-pmalani@chromium.org> <20220607190131.1647511-4-pmalani@chromium.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 08/06/2022 19:15, Prashant Malani wrote: > Hi Krzysztof, > > On Jun 08 11:18, Krzysztof Kozlowski wrote: >> On 07/06/2022 21:00, Prashant Malani wrote: >>> Introduce a binding which represents a component that can control the >>> routing of USB Type-C data lines as well as address data line >>> orientation (based on CC lines' orientation). >>> >>> Signed-off-by: Prashant Malani >>> --- >>> .../devicetree/bindings/usb/typec-switch.yaml | 76 +++++++++++++++++++ >>> 1 file changed, 76 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/usb/typec-switch.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/usb/typec-switch.yaml b/Documentation/devicetree/bindings/usb/typec-switch.yaml >>> new file mode 100644 >>> index 000000000000..60a600a63fef >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/typec-switch.yaml >>> @@ -0,0 +1,76 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/usb/typec-switch.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: USB Type-C Switch >>> + >>> +maintainers: >>> + - Prashant Malani >>> + >>> +description: >>> + A USB Type-C switch represents a component which routes USB Type-C data >>> + lines to various protocol host controllers (e.g USB, VESA DisplayPort, >>> + Thunderbolt etc.) depending on which mode the Type-C port, port partner >>> + and cable are operating in. It can also modify lane routing based on >>> + the orientation of a connected Type-C peripheral. >>> + >>> +properties: >>> + compatible: >>> + items: >> >> Single item, so no need for items. > > I tried this initially, but dt_binding_check throws the following > error: > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/typec-switch.yaml > > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > /foo/linux/Documentation/devicetree/bindings/usb/typec-switch.yaml: properties:compatible: [{'enum': ['typec-switch']}] is not of type 'object', 'boolean' > from schema $id: http://json-schema.org/draft-07/schema# > SCHEMA Documentation/devicetree/bindings/processed-schema.json > /foo/linux/Documentation/devicetree/bindings/usb/typec-switch.yaml: ignoring, error in schema: properties: compatible Probably you messed up the syntax in the enum. Just open some examples: git grep -C 3 'properties:' -- Documentation/devicetree/bindings/*/*yaml Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml Best regards, Krzysztof