From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDCEC432BE for ; Fri, 27 Aug 2021 15:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 796E760F5B for ; Fri, 27 Aug 2021 15:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235955AbhH0P5s (ORCPT ); Fri, 27 Aug 2021 11:57:48 -0400 Received: from mxout03.lancloud.ru ([45.84.86.113]:53124 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234232AbhH0P5s (ORCPT ); Fri, 27 Aug 2021 11:57:48 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru DB66120D475F Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH] usb: core: hcd: merge repetitive strings in usb_hcd_request_irqs() From: Sergey Shtylyov To: Greg Kroah-Hartman CC: References: <3d811f11-cd42-08f4-73a5-642e1c82045c@omp.ru> Organization: Open Mobile Platform Message-ID: Date: Fri, 27 Aug 2021 18:56:55 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <3d811f11-cd42-08f4-73a5-642e1c82045c@omp.ru> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 26.08.2021 20:39, Sergey Shtylyov wrote: [...] >>> Two dev_info() calls in usb_hcd_request_irqs() have the same "io " strings >>> needlessly repeated. Merge these strings into the format strings of those >>> dev_info() calls... >>> >>> Signed-off-by: Sergey Shtylyov >>> >>> --- >>> The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo... >>> >>> drivers/usb/core/hcd.c | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >>> >>> Index: usb/drivers/usb/core/hcd.c >>> =================================================================== >>> --- usb.orig/drivers/usb/core/hcd.c >>> +++ usb/drivers/usb/core/hcd.c >>> @@ -2730,16 +2730,16 @@ static int usb_hcd_request_irqs(struct u >>> return retval; >>> } >>> hcd->irq = irqnum; >>> - dev_info(hcd->self.controller, "irq %d, %s 0x%08llx\n", irqnum, >>> - (hcd->driver->flags & HCD_MEMORY) ? >>> - "io mem" : "io base", >>> - (unsigned long long)hcd->rsrc_start); >>> + dev_info(hcd->self.controller, "irq %d, io %s 0x%08llx\n", >>> + irqnum, (hcd->driver->flags & HCD_MEMORY) ? >>> + "mem" : "base", >>> + (unsigned long long)hcd->rsrc_start); >> >> This now makes it harder to grep for messages in the kernel source :( > > Mhm, maybe... > >> As this saves almost no memory, I'll just ignore this patch. > > I also didn't find the current strings adequate -- I'd understand "io mem" vs "io port", > not what it is now... Indeed, HCD_MEMORY means MMIO, else means I/O ports. Would the patch fixing this substring be acceptable instead of this one? >> thanks, >> >> greg k-h MBR, Sergey