From: Florian Fainelli <f.fainelli@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>, justinpopo6@gmail.com
Cc: alcooperx@gmail.com, balbi@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, justin.chen@broadcom.com,
f.fainelli@gmail.com
Subject: Re: [PATCH] usb: bdc: change state when port disconnected
Date: Mon, 10 Oct 2022 07:58:55 -0700 [thread overview]
Message-ID: <f0706380-94f9-ed7d-1033-8da51aab6b01@gmail.com> (raw)
In-Reply-To: <Y0Gax8SUoq59hdoF@kroah.com>
On 10/8/2022 8:44 AM, Greg KH wrote:
> On Wed, Oct 05, 2022 at 12:13:55PM -0700, justinpopo6@gmail.com wrote:
>> From: Justin Chen <justinpopo6@gmail.com>
>>
>> When port is connected and then disconnected, the state stays as
>> configured. Which is incorrect as the port is no longer configured,
>> but in a not attached state.
>>
>> Signed-off-by: Justin Chen <justinpopo6@gmail.com>
>> ---
>> drivers/usb/gadget/udc/bdc/bdc_udc.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> What commit id does this fix? Should it go to older kernels? If so,
> how far back?
This would be:
Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for Broadcom USB3.0
device controller IP BDC")
that issue was present since the driver was included in Linux with the
commit above, we did not really consider it to be a serious enough bug,
but I suppose it would not hurt to affix the said Fixes tag.
--
Florian
next prev parent reply other threads:[~2022-10-10 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 19:13 [PATCH] usb: bdc: change state when port disconnected justinpopo6
2022-10-05 20:35 ` Florian Fainelli
2022-10-08 15:44 ` Greg KH
2022-10-10 14:58 ` Florian Fainelli [this message]
2022-10-17 21:05 ` Florian Fainelli
2022-10-22 10:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0706380-94f9-ed7d-1033-8da51aab6b01@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alcooperx@gmail.com \
--cc=balbi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=justin.chen@broadcom.com \
--cc=justinpopo6@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).