From: Frank Wang <frank.wang@rock-chips.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux@roeck-us.net, gregkh@linuxfoundation.org, heiko@sntech.de,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, huangtao@rock-chips.com,
william.wu@rock-chips.com, jianwei.zheng@rock-chips.com,
yubing.zhang@rock-chips.com, wmc@rock-chips.com
Subject: Re: [PATCH 1/4] usb: typec: tcpm: fix cc role at port reset
Date: Wed, 15 Mar 2023 10:55:20 +0800 [thread overview]
Message-ID: <f0f0ac72-0a90-da9e-f686-49c21a76866b@rock-chips.com> (raw)
In-Reply-To: <ZBA8Y/dbozOk2df7@kuha.fi.intel.com>
Hi Heikki,
On 2023/3/14 17:20, Heikki Krogerus wrote:
> On Mon, Mar 13, 2023 at 10:58:40AM +0800, Frank Wang wrote:
>> In the current implementation, the tcpm set CC1/CC2 role to open when
>> it do port reset would cause the VBUS removed by the Type-C partner.
>>
>> The Figure 4-20 in the TCPCI 2.0 specification show that the CC1/CC2
>> role should set to 01b (Rp) or 10b (Rd) at Power On or Reset stage
>> in DRP initialization and connection detection.
>>
>> So set CC1/CC2 to Rd to fix it.
>>
>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>> ---
>> drivers/usb/typec/tcpm/tcpm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
>> index a0d943d785800..66de02a56f512 100644
>> --- a/drivers/usb/typec/tcpm/tcpm.c
>> +++ b/drivers/usb/typec/tcpm/tcpm.c
>> @@ -4851,7 +4851,7 @@ static void run_state_machine(struct tcpm_port *port)
>> break;
>> case PORT_RESET:
>> tcpm_reset_port(port);
>> - tcpm_set_cc(port, TYPEC_CC_OPEN);
>> + tcpm_set_cc(port, TYPEC_CC_RD);
>> tcpm_set_state(port, PORT_RESET_WAIT_OFF,
>> PD_T_ERROR_RECOVERY);
>> break;
> Will this work if the port is for example source only?
Yeah, this only set at port reset stage and CC value will be set again
(Rd for Sink, Rp_* for Source) when start toggling.
BR.
Frank
next prev parent reply other threads:[~2023-03-15 2:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 2:58 [PATCH 0/4] Fix some defects related Type-C TCPM Frank Wang
2023-03-13 2:58 ` [PATCH 1/4] usb: typec: tcpm: fix cc role at port reset Frank Wang
2023-03-14 9:20 ` Heikki Krogerus
2023-03-15 2:55 ` Frank Wang [this message]
2023-03-17 11:24 ` Heikki Krogerus
2023-03-17 12:47 ` Guenter Roeck
2023-03-20 2:28 ` Frank Wang
2023-03-13 2:58 ` [PATCH 2/4] usb: typec: tcpm: fix multiple times discover svids error Frank Wang
2023-03-14 9:22 ` Heikki Krogerus
2023-03-15 2:57 ` Frank Wang
2023-03-13 2:58 ` [PATCH 3/4] usb: typec: tcpm: add get max power support Frank Wang
2023-03-13 2:58 ` [PATCH 4/4] usb: typec: tcpm: fix source caps may lost after soft reset Frank Wang
2023-03-17 12:58 ` Guenter Roeck
2023-03-20 2:38 ` Frank Wang
2023-03-20 3:35 ` Guenter Roeck
2023-03-20 6:28 ` Frank Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f0ac72-0a90-da9e-f686-49c21a76866b@rock-chips.com \
--to=frank.wang@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jianwei.zheng@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=william.wu@rock-chips.com \
--cc=wmc@rock-chips.com \
--cc=yubing.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).