From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Roger Quadros <rogerq@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add documentation for AM62 USB Wrapper module
Date: Wed, 23 Mar 2022 10:05:54 +0100 [thread overview]
Message-ID: <f17f1f14-d78f-7b54-7fa7-ebf52c6da90a@kernel.org> (raw)
In-Reply-To: <20220323053524.7009-2-a-govindraju@ti.com>
On 23/03/2022 06:35, Aswath Govindraju wrote:
> Add bindings for the TI's AM62 wrapper module for the Synopsys USBSS-DRD
> controller.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> .../devicetree/bindings/usb/ti,am62-usb.yaml | 98 +++++++++++++++++++
> 1 file changed, 98 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> new file mode 100644
> index 000000000000..4bb139d1926d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/ti,am62-usb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bindings for the TI's AM62 wrapper module for the Synopsys USBSS-DRD controller
Skip the "Bindings for the", just leave the HW description.
> +
> +maintainers:
> + - Aswath Govindraju <a-govindraju@ti.com>
> +
> +properties:
> + compatible:
> + const: ti,am62-usb
> +
> + reg:
> + maxItems: 1
> +
> + ranges: true
> +
> + power-domains:
> + description:
> + PM domain provider node and an args specifier containing
> + the USB ISO device id value. See,
> + Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
> + maxItems: 1
> +
> + clocks:
> + description: Clock phandles to usb2_refclk
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: ref
> +
> + id-gpio:
> + description:
> + GPIO to be used as ID pin
> + maxItems: 1
> +
> + interrupts:
> + description:
> + interrupt line to be used for detecting changes in VBUS
> +
> + ti,vbus-divider:
> + description:
> + Should be present if USB VBUS line is connected to the
> + VBUS pin of the SoC via a 1/3 voltage divider.
> + type: boolean
> +
> + ti,syscon-phy-pll-refclk:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: Phandle to the SYSCON entry
> + - description: USB phy control register offset within SYSCON
> + description: Specifier for configuring frequency of ref clock input.
This is a bit strange. The ref clock is the "ref" input clock, right? In
such case use clk_set_rate()... Using syscon for managing clocks is not
the proper way.
Plus all the issues pointed out by Roger.
> +
> + '#address-cells':
> + const: 2
> +
> + '#size-cells':
> + const: 2
No children allowed?
I understand this is a wrapper, which explains why you do not include
usb-hcd.yaml schema. But since it is a wrapper, what is it wrapping?
> +
> +required:
> + - compatible
> + - reg
> + - power-domains
> + - clocks
> + - clock-names
> + - interrupts
> + - ti,syscon-phy-pll-refclk
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/soc/ti,sci_pm_domain.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/gpio/gpio.h>
> +
> + bus {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + dwc3-usb@f910000 {
Generic node name, so usb.
> + compatible = "ti,am62-usb";
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-23 9:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 5:35 [PATCH 0/2] AM62: Add support for AM62 USB wrapper driver Aswath Govindraju
2022-03-23 5:35 ` [PATCH 1/2] dt-bindings: usb: Add documentation for AM62 USB Wrapper module Aswath Govindraju
2022-03-23 6:17 ` Roger Quadros
2022-03-23 6:19 ` Roger Quadros
2022-03-23 7:54 ` Roger Quadros
2022-03-23 9:05 ` Krzysztof Kozlowski [this message]
2022-03-23 9:17 ` Aswath Govindraju
2022-03-23 9:21 ` Krzysztof Kozlowski
2022-03-23 5:35 ` [PATCH 2/2] drivers: usb: dwc3: Add AM62 USB wrapper driver Aswath Govindraju
2022-03-23 9:33 ` kernel test robot
2022-03-23 12:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17f1f14-d78f-7b54-7fa7-ebf52c6da90a@kernel.org \
--to=krzk@kernel.org \
--cc=a-govindraju@ti.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).