From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: use proper initializers for property entries
Date: Tue, 7 Jan 2020 12:32:33 +0100 [thread overview]
Message-ID: <f2f41b28-2ca5-7fad-5b19-2ad51c689e5a@samsung.com> (raw)
In-Reply-To: <2a8a5e6b-9372-978e-03d0-350ab65a2d0a@redhat.com>
Hi All,
On 15.12.2019 17:41, Hans de Goede wrote:
> Hi,
>
> On 13-12-2019 18:46, Dmitry Torokhov wrote:
>> We should not be reaching into property entries and initialize them by
>> hand, but rather use proper initializer macros. This way we can alter
>> internal representation of property entries with no visible changes to
>> their users.
>>
>> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> ---
>>
>> It would be good if this could go through Rafael's tree as it is needed
>> for the rest of my software_node/property_entry rework patch series
>> which I would love not to delay till 5.6.
>
> Patch looks good to me:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
This patch is instantly needed as the issue it fixes is again triggered
in current (20200107) linux-next by commit e6bff4665c59 "software node:
replace is_array with is_inline".
Felipe: could You ack it, so it could be merged via Rafael's tree
together with related device property changes?
>>
>> drivers/usb/dwc3/host.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
>> index 5567ed2cddbec..fa252870c926f 100644
>> --- a/drivers/usb/dwc3/host.c
>> +++ b/drivers/usb/dwc3/host.c
>> @@ -88,10 +88,10 @@ int dwc3_host_init(struct dwc3 *dwc)
>> memset(props, 0, sizeof(struct property_entry) *
>> ARRAY_SIZE(props));
>> if (dwc->usb3_lpm_capable)
>> - props[prop_idx++].name = "usb3-lpm-capable";
>> + props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb3-lpm-capable");
>> if (dwc->usb2_lpm_disable)
>> - props[prop_idx++].name = "usb2-lpm-disable";
>> + props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb2-lpm-disable");
>> /**
>> * WORKAROUND: dwc3 revisions <=3.00a have a limitation
>> @@ -103,7 +103,7 @@ int dwc3_host_init(struct dwc3 *dwc)
>> * This following flag tells XHCI to do just that.
>> */
>> if (dwc->revision <= DWC3_REVISION_300A)
>> - props[prop_idx++].name = "quirk-broken-port-ped";
>> + props[prop_idx++] =
>> PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");
>> if (prop_idx) {
>> ret = platform_device_add_properties(xhci, props);
>>
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-01-07 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 17:46 [PATCH] usb: dwc3: use proper initializers for property entries Dmitry Torokhov
2019-12-15 16:41 ` Hans de Goede
2020-01-07 11:32 ` Marek Szyprowski [this message]
2020-01-09 9:08 ` Felipe Balbi
2020-01-09 9:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f41b28-2ca5-7fad-5b19-2ad51c689e5a@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=balbi@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).