From: Nagarjuna Kristam <nkristam@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: <balbi@kernel.org>, <gregkh@linuxfoundation.org>,
<jonathanh@nvidia.com>, <mark.rutland@arm.com>,
<robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [Patch V6 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller
Date: Thu, 22 Aug 2019 16:05:30 +0530 [thread overview]
Message-ID: <f48e97e5-4ceb-7c83-de6a-4f29cf1945cf@nvidia.com> (raw)
In-Reply-To: <20190822091248.GD23873@ulmo>
On 22-08-2019 14:42, Thierry Reding wrote:
> On Thu, Aug 08, 2019 at 03:07:25PM +0530, Nagarjuna Kristam wrote:
>> This patch adds UDC driver for tegra XUSB 3.0 device mode controller.
>> XUSB device mode controller supports SS, HS and FS modes
>>
>> Based on work by:
>> Mark Kuo <mkuo@nvidia.com>
>> Hui Fu <hfu@nvidia.com>
>> Andrew Bresticker <abrestic@chromium.org>
>>
>> Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
>> Acked-by: Thierry Reding <treding@nvidia.com>
>> ---
>> drivers/usb/gadget/udc/Kconfig | 11 +
>> drivers/usb/gadget/udc/Makefile | 1 +
>> drivers/usb/gadget/udc/tegra_xudc.c | 3808 +++++++++++++++++++++++++++++++++++
>> 3 files changed, 3820 insertions(+)
>> create mode 100644 drivers/usb/gadget/udc/tegra_xudc.c
>>
>> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
>> index ef0259a..fe6028e 100644
>> --- a/drivers/usb/gadget/udc/Kconfig
>> +++ b/drivers/usb/gadget/udc/Kconfig
>> @@ -440,6 +440,17 @@ config USB_GADGET_XILINX
>> dynamically linked module called "udc-xilinx" and force all
>> gadget drivers to also be dynamically linked.
>>
>> +config USB_TEGRA_XUDC
>> + tristate "NVIDIA Tegra Superspeed USB 3.0 Device Controller"
>> + depends on ARCH_TEGRA
>> + select USB_ROLE_SWITCH
>> + help
>> + Enables NVIDIA Tegra USB 3.0 device mode controller driver.
>> +
>> + Say "y" to link the driver statically, or "m" to build a
>> + dynamically linked module called "tegra_xudc" and force all
>> + gadget drivers to also be dynamically linked.
>> +
>> source "drivers/usb/gadget/udc/aspeed-vhub/Kconfig"
>>
>> #
>> diff --git a/drivers/usb/gadget/udc/Makefile b/drivers/usb/gadget/udc/Makefile
>> index 897f648..1c55c96 100644
>> --- a/drivers/usb/gadget/udc/Makefile
>> +++ b/drivers/usb/gadget/udc/Makefile
>> @@ -24,6 +24,7 @@ obj-$(CONFIG_USB_BCM63XX_UDC) += bcm63xx_udc.o
>> obj-$(CONFIG_USB_FSL_USB2) += fsl_usb2_udc.o
>> fsl_usb2_udc-y := fsl_udc_core.o
>> fsl_usb2_udc-$(CONFIG_ARCH_MXC) += fsl_mxc_udc.o
>> +obj-$(CONFIG_USB_TEGRA_XUDC) += tegra_xudc.o
>
> Nit: I have a slight preference for tegra-xudc.o over tegra_xudc.o. We
> use dashes rather than underscores pretty consistently on Tegra, so it
> would be good to keep the same pattern here, unless somebody feels
> strongly about the underscore.
>
> It doesn't matter that much because module utilities treat them the same
> way I think, so the Acked-by remains valid either way.
>
> Thierry
>
Thierry,
Reason to keep tegra_xudc.c instead of tegra-xudc.c is to inline with local file naming.
I will use tegra-xudc.c name in next version, to be inline with other tegra files across
kernel.
Thanks,
Nagarjuna
next prev parent reply other threads:[~2019-08-22 10:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 9:37 [Patch V6 0/8] Tegra XUSB gadget driver support Nagarjuna Kristam
2019-08-08 9:37 ` [Patch V6 1/8] phy: tegra: xusb: Add XUSB dual mode support on Tegra210 Nagarjuna Kristam
2019-08-08 9:37 ` [Patch V6 2/8] phy: tegra: xusb: Add usb3 port fake " Nagarjuna Kristam
2019-08-08 9:37 ` [Patch V6 3/8] phy: tegra: xusb: Add vbus override " Nagarjuna Kristam
2019-08-22 9:04 ` Thierry Reding
2019-08-08 9:37 ` [Patch V6 4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding Nagarjuna Kristam
2019-08-21 20:52 ` Rob Herring
2019-08-22 9:04 ` Thierry Reding
2019-08-08 9:37 ` [Patch V6 5/8] arm64: tegra: Add xudc node for Tegra210 Nagarjuna Kristam
2019-08-08 9:37 ` [Patch V6 6/8] arm64: tegra: Enable xudc on Jetson TX1 Nagarjuna Kristam
2019-08-08 9:37 ` [Patch V6 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller Nagarjuna Kristam
2019-08-09 12:03 ` Felipe Balbi
2019-08-22 10:29 ` Nagarjuna Kristam
2019-08-09 14:28 ` kbuild test robot
2019-08-12 12:43 ` Chunfeng Yun
2019-08-12 12:49 ` Felipe Balbi
2019-08-12 13:00 ` Chunfeng Yun
2019-08-13 10:16 ` Nagarjuna Kristam
2019-08-22 9:12 ` Thierry Reding
2019-08-22 10:35 ` Nagarjuna Kristam [this message]
2019-08-08 9:37 ` [Patch V6 8/8] arm64: defconfig: Enable tegra XUDC driver Nagarjuna Kristam
2019-08-22 9:07 ` [Patch V6 0/8] Tegra XUSB gadget driver support Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f48e97e5-4ceb-7c83-de6a-4f29cf1945cf@nvidia.com \
--to=nkristam@nvidia.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).