Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: liulongfang <liulongfang@huawei.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: <gregkh@linuxfoundation.org>, <mathias.nyman@intel.com>,
	<liudongdong3@huawei.com>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kong.kongxinwei@hisilicon.com>,
	<yisen.zhuang@huawei.com>
Subject: Re: [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem
Date: Fri, 9 Apr 2021 10:42:35 +0800
Message-ID: <f5eb92ab-9d28-d4a9-a3a0-6a759656ad37@huawei.com> (raw)
In-Reply-To: <20210408145332.GA1296449@rowland.harvard.edu>

On 2021/4/8 22:53, Alan Stern wrote:
> On Thu, Apr 08, 2021 at 09:49:18PM +0800, Longfang Liu wrote:
>> (1) Add a whitelist for EHCI devices without SBRN registers.
>> (2) Add Kunpeng920's EHCI device to the whitelist.
>>
>> Changes in v2:
>> 	- Fix some code style issues.
>> 	- Update function name.
>>
>> Longfang Liu (2):
>>   USB:ehci:Add a whitelist for EHCI controllers
>>   USB:ehci:fix Kunpeng920 ehci hardware problem
>>
>>  drivers/usb/host/ehci-pci.c | 30 ++++++++++++++++++++++++++----
>>  1 file changed, 26 insertions(+), 4 deletions(-)
> 
> I don't think we need a whole list, along with an associated lookup 
> routine, when there are only two entries.  The total amount of code will 
> be smaller if you just add a check for the Kunpeng920 controller to
> the existing check for the STMICRO controller.
> 
> Alan Stern
> .
> 
Now there are two EHCI controllers that do not have SBRN registers,
and there may be more in the future. This list is added for subsequent
compatibility if there are such controllers, instead of a series of if-else.
Thanks.
Longfang.

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 13:49 Longfang Liu
2021-04-08 13:49 ` [PATCH v2 1/2] USB:ehci:Add a whitelist for EHCI controllers Longfang Liu
2021-04-08 14:53   ` Greg KH
2021-04-08 17:30   ` kernel test robot
2021-04-08 20:34   ` kernel test robot
2021-04-08 13:49 ` [PATCH v2 2/2] USB:ehci:fix Kunpeng920 ehci hardware problem Longfang Liu
2021-04-08 14:53 ` [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem Alan Stern
2021-04-09  2:42   ` liulongfang [this message]
2021-04-09  6:47     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5eb92ab-9d28-d4a9-a3a0-6a759656ad37@huawei.com \
    --to=liulongfang@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=liudongdong3@huawei.com \
    --cc=mathias.nyman@intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git