Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* g_multi rmmod problem: usb_put_function_instance(fi_acm) hangs
@ 2020-01-13 15:16 Martin Kepplinger
  0 siblings, 0 replies; only message in thread
From: Martin Kepplinger @ 2020-01-13 15:16 UTC (permalink / raw)
  To: Felipe Balbi; +Cc: gregkh, linux-usb, linux-kernel

hi,

on the librem5 with defconfig
https://source.puri.sm/martin.kepplinger/linux-next/blob/next-20200110/librem5_cpuidle_mainline_atf/arch/arm64/configs/librem5_defconfig
running next-20200110 I load g_multi during startup.

rmmod g_multi results in error like
[  190.995685] dwc3 38100000.usb: timed out waiting for SETUP phase
or
[  109.702545] dwc3 38100000.usb: failed to enable ep0out

and hangs rmmod. What "fixes" the problem is the following change below.
Does that make any sense to you?

How would a real fix look like here, or how would I further debug?

thanks,
                                 martin

--- a/drivers/usb/gadget/legacy/multi.c
+++ b/drivers/usb/gadget/legacy/multi.c
@@ -459,7 +459,8 @@ static int multi_unbind(struct usb_composite_dev *cdev)
 #ifdef USB_ETH_RNDIS
        usb_put_function(f_acm_rndis);
 #endif
-       usb_put_function_instance(fi_acm);
+       /* FIXME the following hangs during rmmod */
+       // usb_put_function_instance(fi_acm);
 #ifdef USB_ETH_RNDIS
        usb_put_function(f_rndis);
        usb_put_function_instance(fi_rndis);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 15:16 g_multi rmmod problem: usb_put_function_instance(fi_acm) hangs Martin Kepplinger

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git