From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B130C43334 for ; Wed, 8 Jun 2022 09:54:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235082AbiFHJye (ORCPT ); Wed, 8 Jun 2022 05:54:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236187AbiFHJyJ (ORCPT ); Wed, 8 Jun 2022 05:54:09 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4963A27E46D for ; Wed, 8 Jun 2022 02:24:44 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id fu3so38730607ejc.7 for ; Wed, 08 Jun 2022 02:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zSLdyx64qSe5gyHdS5UlkceB2srWq2wpIjxpdBXJ6s8=; b=jWCXP7B8PfneXoA78HERkc5WPZXWIGc4PTf3ej4mJ1w5NNxASuN1mTgM5THK3gz5eM vDQdSPs27hgYuMmswEPRhnu7WRi/MWr4V34+WzzC8yg154n3hUTKJcaTHrqNQ6Zpmnj7 JbA91n12TX41v9Tw8UT2qKLxraz6N9YYg3Fx/nRqYevY+J91DxuoB0t0c9ZYxpMm5WXf SdmlyWvXMyLlCCNLNd8UUyLreq+xj3nXjZSi6P/QPMeEqFbeHv26PZ0NqP51eEcNC59N OGd59Seqm0KzfoS8cOxoGhh1rug91Lkk4nisNI0c3V5ehiW0iVFWOA3X0rdYeYIc5J09 XIvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zSLdyx64qSe5gyHdS5UlkceB2srWq2wpIjxpdBXJ6s8=; b=BlgEATWN9NqlIGX53omoq2fTnBmtkk4l/3Y2vWqeYF0BwhumLj2wxZyuWWH9qjnwVz BC9Q5Te89LFFeP+GF9GdiQP5g6ttPxOPfdUZlFHfXk2AN6ozGZ8dPjrStmkzu7VyFKFE +aQRBnWO300H2rCM2Z9dlU2QSzAuyBTmhEZEGhG14cuCltK9QZ6k9WWA69klUyLLcm8y 656cajy9CC+e7r/pK893K8pvjdJgOlOTBcJLSxf5/Pk5y3SivfUBT4BQQe5TlPMvBJ/E umMGbMrqahVHfY4GWSmqhcKoXDnSY7zxSrp9HkvSP7eTjqPxIU/elhb4Mu5MUZrz3sTi FRPg== X-Gm-Message-State: AOAM530BZ5QuxQR6SJowR+dnRo119D1/AP3NnOD8vBf9+KcxcVW20Dnl KIjmgeVNbiUB3erxeWDm2bhl1Q== X-Google-Smtp-Source: ABdhPJxYV9tBPj4dwnLBO37vz7PvVAGcb41V0vK9tvKORk36nT5oq7EgD1nyvt40Zy6yk44yCYsFAQ== X-Received: by 2002:a17:907:2d0c:b0:711:e835:f80c with SMTP id gs12-20020a1709072d0c00b00711e835f80cmr5450514ejc.257.1654680282700; Wed, 08 Jun 2022 02:24:42 -0700 (PDT) Received: from [192.168.0.191] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id b6-20020a17090636c600b006feb6dee4absm8887348ejc.137.2022.06.08.02.24.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 02:24:42 -0700 (PDT) Message-ID: Date: Wed, 8 Jun 2022 11:24:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Content-Language: en-US To: Prashant Malani , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: bleung@chromium.org, swboyd@chromium.org, heikki.krogerus@linux.intel.com, Andrzej Hajda , Daniel Vetter , David Airlie , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:DRM DRIVERS" , Greg Kroah-Hartman , Hsin-Yi Wang , Jernej Skrabec , Jonas Karlman , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Krzysztof Kozlowski , Laurent Pinchart , Maxime Ripard , Neil Armstrong , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Pin-Yen Lin , Robert Foss , Rob Herring , Sam Ravnborg , Thomas Zimmermann , Xin Ji References: <20220607190131.1647511-1-pmalani@chromium.org> <20220607190131.1647511-5-pmalani@chromium.org> From: Krzysztof Kozlowski In-Reply-To: <20220607190131.1647511-5-pmalani@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 07/06/2022 21:00, Prashant Malani wrote: > Analogix 7625 can be used in systems to switch USB Type-C DisplayPort > alternate mode lane traffic between 2 Type-C ports. > > Update the binding to accommodate this usage by introducing a switch > property. > > Signed-off-by: Prashant Malani > --- > .../display/bridge/analogix,anx7625.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 35a48515836e..7e1f655ddfcc 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -105,6 +105,26 @@ properties: > - port@0 > - port@1 > > + switches: > + type: object > + description: Set of switches controlling DisplayPort traffic on > + outgoing RX/TX lanes to Type C ports. > + > + properties: > + switch: You allow only one switch with such schema, so no need for "switches"... > + $ref: /schemas/usb/typec-switch.yaml# > + maxItems: 2 Are you sure this works? what are you limiting here with maxItems? I think you wanted patternProperties... > + > + properties: > + reg: > + maxItems: 1 > + > + required: > + - reg > + > + required: > + - switch@0 This does not match the property. You also need unevaluatedProperties:false > + > required: > - compatible > - reg > @@ -167,5 +187,41 @@ examples: > }; > }; > }; > + switches { > + #address-cells = <1>; > + #size-cells = <0>; > + switch@0 { > + compatible = "typec-switch"; > + reg = <0>; > + mode-switch; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + anx_typec0: endpoint { > + remote-endpoint = <&typec_port0>; Messed up indentation. Your previous patch should also switch to 4-space as recommended by schema coding style. > + }; > + }; > + }; > + }; > + switch@1 { > + compatible = "typec-switch"; > + reg = <1>; > + mode-switch; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + anx_typec1: endpoint { > + remote-endpoint = <&typec_port1>; Ditto. > + }; > + }; > + }; > + }; > + }; > }; > }; Best regards, Krzysztof