linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: linux-usb@vger.kernel.org
Cc: "Marek Vasut" <marex@denx.de>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Yassine Oudjana" <y.oudjana@protonmail.com>,
	"Alvin Šipraga" <ALSI@bang-olufsen.dk>,
	regressions@lists.linux.dev
Subject: Re: [PATCH 2/2] extcon: usbc-tusb320: Add USB TYPE-C support
Date: Sun, 13 Nov 2022 17:59:44 +0100	[thread overview]
Message-ID: <fd0f2d56-495e-6fdd-d1e8-ff40b558101e@axentia.se> (raw)

On Sat, Jul 30, 2022 at 08:05:00PM +0200, Marek Vasut wrote:
> The TI TUSB320 seems like a better fit for USB TYPE-C subsystem,
> which can expose details collected by the TUSB320 in a far more
> precise way than extcon. Since there are existing users in the
> kernel and in DT which depend on the extcon interface, keep it
> for now.
> 
> Add TYPE-C interface and expose the supported supply current,
> direction and connector polarity via the TYPE-C interface.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Hi!

I'm very sad to report that this patch has caused a severe
regression for our devices. They can no longer be powered by simply
sticking a USB cable into their USB ports (they keep resetting
when the tusb320 driver probes), and they reset (and keep resetting)
if a USB cable is connected while the device is powered by other
means.

We have no connector node nor any typec-power-opmode property
in the device tree, so the mere touching of the new registers
happening in this patch is enough to cause the resets.

The devices were fine before this patch, and reverting on top
of a recent linus master (4bbf3422df78, from 11/11) makes the
problem go away.

Any suggestions?

Cheers,
Peter

regzbot: introduced bf7571c00dca

             reply	other threads:[~2022-11-13 16:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-13 16:59 Peter Rosin [this message]
2022-11-13 17:38 ` [PATCH 2/2] extcon: usbc-tusb320: Add USB TYPE-C support #forregzbot Thorsten Leemhuis
2022-11-14  5:56   ` Thorsten Leemhuis
2022-11-13 18:48 ` [PATCH 2/2] extcon: usbc-tusb320: Add USB TYPE-C support Marek Vasut
2022-11-13 19:41   ` Peter Rosin
2022-11-13 20:47     ` Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2022-07-30 18:04 [PATCH 1/2] extcon: usbc-tusb320: Factor out extcon into dedicated functions Marek Vasut
2022-07-30 18:05 ` [PATCH 2/2] extcon: usbc-tusb320: Add USB TYPE-C support Marek Vasut
2022-07-30 20:39   ` kernel test robot
2022-07-30 20:49   ` kernel test robot
2022-08-02  7:40   ` Heikki Krogerus
2022-08-23 10:40     ` Marek Vasut
2022-08-23  9:49   ` Alvin Šipraga
2022-08-23 10:39     ` Marek Vasut
2022-08-23 12:57       ` Alvin Šipraga
2022-08-23 14:07         ` Marek Vasut
2022-08-23 22:36   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd0f2d56-495e-6fdd-d1e8-ff40b558101e@axentia.se \
    --to=peda@axentia.se \
    --cc=ALSI@bang-olufsen.dk \
    --cc=cw00.choi@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=regressions@lists.linux.dev \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).